aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 16054: Rewrite SchedulerLifecycle, employing a state machine.
Date Fri, 13 Dec 2013 19:31:10 GMT


> On Dec. 10, 2013, 11:30 p.m., Suman Karumuri wrote:
> > src/main/java/com/twitter/aurora/scheduler/Driver.java, line 76
> > <https://reviews.apache.org/r/16054/diff/2/?file=395766#file395766line76>
> >
> >     Does the comment need to be updated to "starts and runs the underlying driver
..."?

Opting for just s/Runs/Starts/ instead, since that's more accurate.


> On Dec. 10, 2013, 11:30 p.m., Suman Karumuri wrote:
> > src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java, line 73
> > <https://reviews.apache.org/r/16054/diff/2/?file=395768#file395768line73>
> >
> >     More documentation about the big idea behind the state machine, either here
or near the state machine declaration will help in understanding this code faster.

Added more detail, PTAL.


> On Dec. 10, 2013, 11:30 p.m., Suman Karumuri wrote:
> > src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java, line 453
> > <https://reviews.apache.org/r/16054/diff/2/?file=395768#file395768line453>
> >
> >     Since this is a critical piece of config, would it make sense to ensure that
this number is greater than 0 and not in seconds?

Added positive checks in LeadingOptions, i'd rather not be more prescriptive than that.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16054/#review30126
-----------------------------------------------------------


On Dec. 9, 2013, 8:11 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16054/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 8:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change addresses two issues:
>   - Ensure leadership is canceled whenever onDefeated is called
>   - Scheduler should wait for registered to be called before attempting to invoke driver
> 
> Some additional structural changes were made:
>   - Driver.run() is no longer used.  Instead, we invoke Driver.start() (non-blocking),
and the lifecycle uses Driver.join() to await exit.
>     This allows us to avoid jumping through thread-safety hoops in unit tests.
>   - A shim interface (DelayedActions) was added to SchedulerLifecycle to make testing
easier when capturing delayed closures.
> 
> 
> Diffs
> -----
> 
>   src/main/java/com/twitter/aurora/scheduler/Driver.java e8fe170b2d9e1a752b152cedc0e006f10eaa5a11

>   src/main/java/com/twitter/aurora/scheduler/ForwardingSchedulerDriver.java PRE-CREATION

>   src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java 346d52acc5fc9e4841e2dc8b424fc6d46d2cdc8c

>   src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java bd7929d631cf45b4c2c7f39177bbafbd8f659071

>   src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d

>   src/main/java/com/twitter/aurora/scheduler/storage/testing/StorageTestUtil.java ceef9d3bd4b43d2dcac0ab9129ae2b624ab654cf

>   src/test/java/com/twitter/aurora/scheduler/DriverTest.java 5609b0b8b9a26a737558316e8e4fab0235704cb8

>   src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java PRE-CREATION

>   src/test/java/com/twitter/aurora/scheduler/app/SchedulerIT.java 4c381b946c8a3c7bbe1757d384d5d43dd74bb4d0

> 
> Diff: https://reviews.apache.org/r/16054/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message