aurora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 16170: Revert Thrift upgrade.
Date Wed, 11 Dec 2013 01:49:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16170/#review30166
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 11, 2013, 1:32 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16170/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 1:32 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri, Maxim Khutornenko, Bill Farner, and Zameer
Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Revert "Upgrade Thrift to 0.9.1"
> 
> Revert the Thrift upgrade, leaving the compiler flag optimizations in
> place. The upgrade shadowed libthrift 0.5 dependencies, causing
> downstream classpath conflicts.
> 
> This reverts commit e7b3da9c47390ed40aac8a5b17aef6b5a6404274.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/Makefile 56e28fd5e12e1cb3363e265012e9cc04ce02bb38 
>   build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 
>   src/main/java/com/twitter/aurora/scheduler/base/Tasks.java d98da3f9ca8104ebcbed5cdbccaf44ea19b42e2a

>   src/main/java/com/twitter/aurora/scheduler/configuration/ConfigurationManager.java
4839d0f08ae950329378475304f8f3cd09e2a25f 
>   src/main/java/com/twitter/aurora/scheduler/cron/testing/AbstractCronIT.java 6bfc9096a6abda9a249c8c7d39ddff0edf73b085

>   src/main/java/com/twitter/aurora/scheduler/http/SchedulerzJob.java 12b0becd6a998d52d960be84791d06ddfed10989

>   src/main/java/com/twitter/aurora/scheduler/http/SchedulerzRole.java 756c672461e8794e9ed045e5439c76da6c7d37e0

>   src/main/java/com/twitter/aurora/scheduler/storage/log/Entries.java 74e8c070d022d36daebcc01f10a41d05292d2296

>   src/main/java/com/twitter/aurora/scheduler/storage/log/LogManager.java da29401fd623bc69ec807048a0df49604722a82a

>   src/main/java/com/twitter/aurora/scheduler/storage/log/SnapshotStoreImpl.java df6b899ab01e91ef89906aaacddca91e3f0349c9

>   src/main/java/com/twitter/aurora/scheduler/storage/log/testing/LogOpMatcher.java a4c0126716a81a9687d9578181276e632ac34e37

>   src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerAPIServlet.java 2acf5c820bc1548640e5f35c0e1d146844722bba

>   src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftInterface.java 503ac447c364340dc7072d15fd3c94532779f7c1

>   src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftServer.java PRE-CREATION

>   src/main/java/com/twitter/aurora/scheduler/thrift/ThriftModule.java cca90534444906ef3d1d59e31a6b1856c1cbb2dc

>   src/main/java/com/twitter/aurora/scheduler/thrift/ThriftServer.java 7b9abd1948e12d9a42b80dd46833d2ea1267a054

>   src/main/java/com/twitter/aurora/scheduler/thrift/ThriftServerLauncher.java 6743060c4cf98c3b9a94386185faa81eafb74c09

>   src/main/java/com/twitter/aurora/scheduler/thrift/aop/APIVersionInterceptor.java d66a2b29e5a03f098caa131c1092c6dd5180347c

>   src/test/java/com/twitter/aurora/scheduler/app/SchedulerIT.java 4c381b946c8a3c7bbe1757d384d5d43dd74bb4d0

>   src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java
ec9c21c1526a260da474ec1f49ecc3bf55e2da12 
>   src/test/java/com/twitter/aurora/scheduler/state/CronJobManagerTest.java b88ccff2fc86a522ec3d272d763d4ce139ef37c3

>   src/test/java/com/twitter/aurora/scheduler/state/LockManagerImplTest.java ec0c8dd33c34445f6e67bb655701e596d3424b8a

>   src/test/java/com/twitter/aurora/scheduler/state/StateManagerImplTest.java 7de377c66f000b2a16ace1c3d6883274185e450f

>   src/test/java/com/twitter/aurora/scheduler/storage/backup/RecoveryTest.java ded3a3f2552c133097b5c8147a08b0650e4d0b88

>   src/test/java/com/twitter/aurora/scheduler/storage/log/LogManagerTest.java d14fb4be9631fcbf832daa489d16a27eee1f43bd

>   src/test/java/com/twitter/aurora/scheduler/storage/log/LogStorageTest.java e2d1836884546a856320aeef3def5811a2f5215e

>   src/test/java/com/twitter/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 506279518ba29601cfe13d20bf6ef175d1407a18

>   src/test/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
1e1e7b5a9c2805790ed26939e151b727a15ec88d 
> 
> Diff: https://reviews.apache.org/r/16170/diff/
> 
> 
> Testing
> -------
> 
> git clean -fdx build-support
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message