aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject aurora git commit: Restore Linux compatibility of review_feedback.py
Date Tue, 12 Dec 2017 11:56:29 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 0cdaa1509 -> 301f06636


Restore Linux compatibility of review_feedback.py

The "unbuffered" parameter introduced in https://reviews.apache.org/r/64508/
does only work on MacOS.


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/301f0663
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/301f0663
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/301f0663

Branch: refs/heads/master
Commit: 301f066369a9ef7262c1702c77004d12bc8eac00
Parents: 0cdaa15
Author: Stephan Erb <serb@apache.org>
Authored: Tue Dec 12 12:54:45 2017 +0100
Committer: Stephan Erb <serb@apache.org>
Committed: Tue Dec 12 12:54:45 2017 +0100

----------------------------------------------------------------------
 build-support/jenkins/review_feedback.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/301f0663/build-support/jenkins/review_feedback.py
----------------------------------------------------------------------
diff --git a/build-support/jenkins/review_feedback.py b/build-support/jenkins/review_feedback.py
index e1e1e8d..d31247a 100755
--- a/build-support/jenkins/review_feedback.py
+++ b/build-support/jenkins/review_feedback.py
@@ -178,7 +178,7 @@ class RequestProcessor(object):
       result = subprocess.call([
         'bash',
         '-c',
-        'set -o pipefail; %s 2>&1 | tr -u "\r" "\n" | tee %s' % (self._command, build_output)])
+        'set -o pipefail; %s 2>&1 | tr "\r" "\n" | tee %s' % (self._command, build_output)])
       if result == 0:
         review_text = 'Master (%s) is green with this patch.\n  %s' % (sha, self._command)
         if self._missing_tests(latest_diff):


Mime
View raw message