aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zma...@apache.org
Subject aurora git commit: Reduce log output in `VersionedSchedulerDriverService`.
Date Wed, 08 Mar 2017 21:06:15 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 932e90871 -> a07b9edf5


Reduce log output in `VersionedSchedulerDriverService`.

The `acceptOffers` log message outputs the entire `Operation` object which for
the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log
output massive. This reduces the logging to just the type of the operation.

Reviewed at https://reviews.apache.org/r/57404/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/a07b9edf
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/a07b9edf
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/a07b9edf

Branch: refs/heads/master
Commit: a07b9edf5ed670b9bfdec244547b12695e9ce23c
Parents: 932e908
Author: Zameer Manji <zmanji@apache.org>
Authored: Wed Mar 8 13:06:02 2017 -0800
Committer: Zameer Manji <zmanji@apache.org>
Committed: Wed Mar 8 13:06:02 2017 -0800

----------------------------------------------------------------------
 .../aurora/scheduler/mesos/VersionedSchedulerDriverService.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/a07b9edf/src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
b/src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
index 9f39aeb..d928d02 100644
--- a/src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
+++ b/src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
@@ -116,7 +116,8 @@ class VersionedSchedulerDriverService extends AbstractIdleService
   @Override
   public void acceptOffers(OfferID offerId, Collection<Operation> operations, Filters
filter) {
     whenRegistered(() -> {
-      LOG.info("Accepting offer {} with ops {}", offerId, operations);
+      Collection<Operation.Type> opTypes = Collections2.transform(operations, Operation::getType);
+      LOG.info("Accepting offer {} with ops {}", offerId, opTypes);
 
       Futures.getUnchecked(mesosFuture).send(
           Call.newBuilder()


Mime
View raw message