aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject aurora git commit: Log process sampling failures with debug severity
Date Tue, 17 Jan 2017 20:54:14 GMT
Repository: aurora
Updated Branches:
  refs/heads/master b75dfb838 -> 6eda8c8af


Log process sampling failures with debug severity

The observer's logs consist of lots of warnings about being unable to find PIDs.
This is expected when running with the PID isolator, or when checkpoints are out
of date (e.g. after processes were killed by the OOM).

    W0116 14:42:54.694221 3253 process_collector_psutil.py:75] Error during process sampling:
psutil.NoSuchProcess process no longer exists (pid=27727)
    W0116 14:42:54.717905 3253 process_collector_psutil.py:42] Error during process sampling
[pid=10960]: psutil.NoSuchProcess process no longer exists (pid=10960)
    W0116 14:42:54.718089 3253 process_collector_psutil.py:75] Error during process sampling:
psutil.NoSuchProcess process no longer exists (pid=10960)
    W0116 14:42:54.718245 3253 process_collector_psutil.py:42] Error during process sampling
[pid=10026]: psutil.NoSuchProcess process no longer exists (pid=10026)
    W0116 14:42:54.718334 3253 process_collector_psutil.py:75] Error during process sampling:
psutil.NoSuchProcess process no longer exists (pid=10026)

This change adopts the proposal of David Robinson to decrease the severity level
to debug.

Bugs closed: AURORA-1541

Reviewed at https://reviews.apache.org/r/55578/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/6eda8c8a
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/6eda8c8a
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/6eda8c8a

Branch: refs/heads/master
Commit: 6eda8c8af70a83da3fd6f8fc2de4aa539ad44199
Parents: b75dfb8
Author: Stephan Erb <serb@apache.org>
Authored: Tue Jan 17 21:53:18 2017 +0100
Committer: Stephan Erb <serb@apache.org>
Committed: Tue Jan 17 21:53:18 2017 +0100

----------------------------------------------------------------------
 .../python/apache/thermos/monitoring/process_collector_psutil.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/6eda8c8a/src/main/python/apache/thermos/monitoring/process_collector_psutil.py
----------------------------------------------------------------------
diff --git a/src/main/python/apache/thermos/monitoring/process_collector_psutil.py b/src/main/python/apache/thermos/monitoring/process_collector_psutil.py
index 4a1b159..3000e95 100644
--- a/src/main/python/apache/thermos/monitoring/process_collector_psutil.py
+++ b/src/main/python/apache/thermos/monitoring/process_collector_psutil.py
@@ -39,7 +39,7 @@ def process_to_sample(process):
     threads = process.num_threads()
     return ProcessSample(rate, user, system, rss, vms, nice, status, threads)
   except (AccessDenied, NoSuchProcess) as e:
-    log.warning('Error during process sampling [pid=%s]: %s' % (process.pid, e))
+    log.debug('Error during process sampling [pid=%s]: %s' % (process.pid, e))
     return ProcessSample.empty()
 
 
@@ -72,7 +72,7 @@ class ProcessTreeCollector(object):
       new_samples[self._pid] = parent_sample
 
     except (IOError, PsutilError) as e:
-      log.warning('Error during process sampling: %s' % e)
+      log.debug('Error during process sampling: %s' % e)
       self._sample = ProcessSample.empty()
       self._rate = 0.0
 


Mime
View raw message