aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jco...@apache.org
Subject aurora git commit: Fix for AURORA-1739, enables golang thrift bindings to create jobs
Date Fri, 16 Sep 2016 20:55:21 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 783baaefb -> f1e09a9c7


Fix for AURORA-1739, enables golang thrift bindings to create jobs

Change in the thrift API to make thee cronSchedule string in JobConfiguration an optional.

Reviewed at https://reviews.apache.org/r/51973/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/f1e09a9c
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/f1e09a9c
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/f1e09a9c

Branch: refs/heads/master
Commit: f1e09a9c7cc9e67c33eae834ce9a6638a5dcf634
Parents: 783baae
Author: Renan DelValle <rdelval1@binghamton.edu>
Authored: Fri Sep 16 15:55:04 2016 -0500
Committer: Joshua Cohen <jcohen@apache.org>
Committed: Fri Sep 16 15:55:04 2016 -0500

----------------------------------------------------------------------
 RELEASE-NOTES.md                                     | 1 +
 api/src/main/thrift/org/apache/aurora/gen/api.thrift | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/f1e09a9c/RELEASE-NOTES.md
----------------------------------------------------------------------
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 411872b..83f1ca2 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -40,6 +40,7 @@
 - In addition to CPU resources, RAM resources can now be treated as revocable via the scheduler
   commandline flag `-enable_revocable_ram`.
 - Introduce UpdateMetadata fields in JobUpdateRequest to allow clients to store metadata
on update.
+- Changed cronSchedule field inside of JobConfiguration schema to be optional for compatibility
with Go.
 
 ### Deprecations and removals:
 

http://git-wip-us.apache.org/repos/asf/aurora/blob/f1e09a9c/api/src/main/thrift/org/apache/aurora/gen/api.thrift
----------------------------------------------------------------------
diff --git a/api/src/main/thrift/org/apache/aurora/gen/api.thrift b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
index a045a21..0c74665 100644
--- a/api/src/main/thrift/org/apache/aurora/gen/api.thrift
+++ b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
@@ -325,7 +325,7 @@ struct JobConfiguration {
   /**
    * If present, the job will be handled as a cron job with this crontab-syntax schedule.
    */
-  4: string cronSchedule
+  4: optional string cronSchedule
   /** Collision policy to use when handling overlapping cron runs.  Default is KILL_EXISTING.
*/
   5: CronCollisionPolicy cronCollisionPolicy
   /** Task configuration for this job. */


Mime
View raw message