aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zma...@apache.org
Subject aurora git commit: Complete TODO in Tasks.java.
Date Thu, 03 Mar 2016 19:03:31 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 35de88645 -> 98a2bc194


Complete TODO in Tasks.java.

This completes the TODO in Tasks.java by removing the unused code.

Reviewed at https://reviews.apache.org/r/44219/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/98a2bc19
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/98a2bc19
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/98a2bc19

Branch: refs/heads/master
Commit: 98a2bc194f59c807b1076a594f46dd0520adee8c
Parents: 35de886
Author: Zameer Manji <zmanji@apache.org>
Authored: Thu Mar 3 13:58:43 2016 -0500
Committer: Zameer Manji <zmanji@apache.org>
Committed: Thu Mar 3 13:58:43 2016 -0500

----------------------------------------------------------------------
 .../java/org/apache/aurora/scheduler/base/Tasks.java    | 12 ------------
 1 file changed, 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/98a2bc19/src/main/java/org/apache/aurora/scheduler/base/Tasks.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/base/Tasks.java b/src/main/java/org/apache/aurora/scheduler/base/Tasks.java
index 9f625c7..2e13aac 100644
--- a/src/main/java/org/apache/aurora/scheduler/base/Tasks.java
+++ b/src/main/java/org/apache/aurora/scheduler/base/Tasks.java
@@ -15,7 +15,6 @@ package org.apache.aurora.scheduler.base;
 
 import java.util.EnumSet;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 
 import com.google.common.annotations.VisibleForTesting;
@@ -24,13 +23,11 @@ import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Iterables;
-import com.google.common.collect.Maps;
 import com.google.common.collect.Multimap;
 import com.google.common.collect.Multimaps;
 import com.google.common.collect.Ordering;
 
 import org.apache.aurora.gen.ScheduleStatus;
-import org.apache.aurora.gen.ScheduledTask;
 import org.apache.aurora.gen.apiConstants;
 import org.apache.aurora.scheduler.storage.entities.IAssignedTask;
 import org.apache.aurora.scheduler.storage.entities.IJobKey;
@@ -113,11 +110,6 @@ public final class Tasks {
     return task.getAssignedTask().getTaskId();
   }
 
-  // TODO(William Farner: Remove this once the code base is switched to IScheduledTask.
-  public static String id(ScheduledTask task) {
-    return task.getAssignedTask().getTaskId();
-  }
-
   public static Set<String> ids(Iterable<IScheduledTask> tasks) {
     return ImmutableSet.copyOf(Iterables.transform(tasks, Tasks::id));
   }
@@ -126,10 +118,6 @@ public final class Tasks {
     return ids(ImmutableList.copyOf(tasks));
   }
 
-  public static Map<String, IScheduledTask> mapById(Iterable<IScheduledTask>
tasks) {
-    return Maps.uniqueIndex(tasks, Tasks::id);
-  }
-
   /**
    * Get the latest active task or the latest inactive task if no active task exists.
    *


Mime
View raw message