aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zma...@apache.org
Subject aurora git commit: Add `--show-error` to curl when bootstrapping thrift.
Date Wed, 13 Jan 2016 00:07:31 GMT
Repository: aurora
Updated Branches:
  refs/heads/master d542bd1d5 -> 952ef6db3


Add `--show-error` to curl when bootstrapping thrift.

>From the curl documentation:
````
-S, --show-error

When used with -s it makes curl show an error message if it fails.
````

It's possible for curl to fail when grabbing the tarball or patch and this will
show users why it failed.

Testing Done:
Ran `make` in the `build-support/thrift` directory.

Reviewed at https://reviews.apache.org/r/42225/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/952ef6db
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/952ef6db
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/952ef6db

Branch: refs/heads/master
Commit: 952ef6db3e8c7fa94c1f06d7864390dce9bb726e
Parents: d542bd1
Author: Zameer Manji <zmanji@apache.org>
Authored: Tue Jan 12 16:07:24 2016 -0800
Committer: Zameer Manji <zmanji@apache.org>
Committed: Tue Jan 12 16:07:24 2016 -0800

----------------------------------------------------------------------
 build-support/thrift/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/952ef6db/build-support/thrift/Makefile
----------------------------------------------------------------------
diff --git a/build-support/thrift/Makefile b/build-support/thrift/Makefile
index 8b1da2a..c28f414 100644
--- a/build-support/thrift/Makefile
+++ b/build-support/thrift/Makefile
@@ -47,11 +47,11 @@ define calculate_sha256
 endef
 
 $(THRIFT):
-	sha256=$$(curl -s $(THRIFT_URL) | tee $(THRIFT_DISTNAME).tar.gz | $(calculate_sha256)) &&
\
+	sha256=$$(curl -s --show-error $(THRIFT_URL) | tee $(THRIFT_DISTNAME).tar.gz | $(calculate_sha256))
&& \
 	[ "$${sha256}" = "$(THRIFT_SHA256)" ] && \
 	tar zxvf $(THRIFT_DISTNAME).tar.gz && \
 	cd $(THRIFT_DISTNAME) && \
-	sha256=$$(curl -s $(THRIFT_PATCH_URL) | tee thrift.patch | $(calculate_sha256)) &&
\
+	sha256=$$(curl -s --show-error $(THRIFT_PATCH_URL) | tee thrift.patch | $(calculate_sha256))
&& \
 	[ "$${sha256}" = "$(THRIFT_PATCH_SHA256)" ] && \
 	patch -p1 < thrift.patch && \
 	./configure $(THRIFT_CONFIGURE_FLAGS) && \


Mime
View raw message