aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zma...@apache.org
Subject aurora git commit: Eliminate OOB pip install of python deps in CI.
Date Thu, 12 Nov 2015 18:57:03 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 48aedae3a -> b4102defe


Eliminate OOB pip install of python deps in CI.

Under older pants, and thus older pex, distributions were fetched using
urllib and were not robust to flaky connections. Now that Aurora is on
modern pants and pex, which uses the `requests` library for fetching and
includes 5 retries by default, this step should no longer be needed to
ensure stable CI runs.

 build-support/jenkins/build.sh | 7 -------
 pants.ini                      | 5 -----
 2 files changed, 12 deletions(-)

Testing Done:
I still can't quite run `./build-support/jenkins/build.sh` straight up
due to https://issues.apache.org/jira/browse/AURORA-1083 but ran the
following successfully locally which forces re-download of requirements
by pants:
```
$ ./pants clean-all test.pytest --no-fast src/test/python::
```

Bugs closed: AURORA-954

Reviewed at https://reviews.apache.org/r/40208/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/b4102def
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/b4102def
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/b4102def

Branch: refs/heads/master
Commit: b4102defe2e865d0ce2a7346a33a52d243d3ebae
Parents: 48aedae
Author: John Sirois <john.sirois@gmail.com>
Authored: Thu Nov 12 10:56:56 2015 -0800
Committer: Zameer Manji <zmanji@apache.org>
Committed: Thu Nov 12 10:56:56 2015 -0800

----------------------------------------------------------------------
 build-support/jenkins/build.sh | 7 -------
 pants.ini                      | 5 -----
 2 files changed, 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/b4102def/build-support/jenkins/build.sh
----------------------------------------------------------------------
diff --git a/build-support/jenkins/build.sh b/build-support/jenkins/build.sh
index 5cd5242..7277a64 100755
--- a/build-support/jenkins/build.sh
+++ b/build-support/jenkins/build.sh
@@ -20,13 +20,6 @@ date
 # Run all Java tests
 ./gradlew -Pq clean build
 
-# Pre-fetch python dependencies. This is to avoid build flakiness introduced by
-# the resolver used in pants.
-export PIP_DEFAULT_TIMEOUT=60
-mkdir -p third_party
-# We omit mesos.native here since we don't actually build or use it in our unit tests.
-python -m pip install -d third_party -r <(grep -v mesos.native 3rdparty/python/requirements.txt)
-
 # Run Python style checks
 ./build-support/python/isort-check
 ./build-support/python/checkstyle-check src

http://git-wip-us.apache.org/repos/asf/aurora/blob/b4102def/pants.ini
----------------------------------------------------------------------
diff --git a/pants.ini b/pants.ini
index 0bd8ec8..22f6c59 100644
--- a/pants.ini
+++ b/pants.ini
@@ -22,8 +22,3 @@ version: 0.9.1
 
 [python-setup]
 interpreter_requirement: CPython>=2.7,<3
-
-
-[python-repos]
-repos: ['third_party/']
-indexes: ['https://pypi.python.org/simple/']


Mime
View raw message