aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wfar...@apache.org
Subject aurora git commit: Kill extraneous `make clean`.
Date Tue, 24 Nov 2015 22:16:26 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 3e69dd46d -> e3c5c370c


Kill extraneous `make clean`.

We're building from a fresh tarball, so there is no need for a clean.
Importantly, the clean breaks building under centos 7 in
aurora-packaging, so this does less work and fixes that case.

Testing Done:
Locally green for `./build-support/thrift/thriftw 0.9.1 --version`
Bill confirmed the fix works for aurora-packaging CentOS 7.

Reviewed at https://reviews.apache.org/r/40675/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/e3c5c370
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/e3c5c370
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/e3c5c370

Branch: refs/heads/master
Commit: e3c5c370cf201168d8eb41f8abbbac1df0671a72
Parents: 3e69dd4
Author: John Sirois <john.sirois@gmail.com>
Authored: Tue Nov 24 14:16:16 2015 -0800
Committer: Bill Farner <wfarner@apache.org>
Committed: Tue Nov 24 14:16:16 2015 -0800

----------------------------------------------------------------------
 build-support/thrift/Makefile | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/e3c5c370/build-support/thrift/Makefile
----------------------------------------------------------------------
diff --git a/build-support/thrift/Makefile b/build-support/thrift/Makefile
index 11d597d..8b1da2a 100644
--- a/build-support/thrift/Makefile
+++ b/build-support/thrift/Makefile
@@ -55,7 +55,6 @@ $(THRIFT):
 	[ "$${sha256}" = "$(THRIFT_PATCH_SHA256)" ] && \
 	patch -p1 < thrift.patch && \
 	./configure $(THRIFT_CONFIGURE_FLAGS) && \
-	make clean && \
 	make -j4
 
 clean:


Mime
View raw message