aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zma...@apache.org
Subject aurora git commit: Maintain compatibility with Health Handler before javax refactor.
Date Fri, 18 Sep 2015 22:30:25 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 9a6832fea -> 1ff336ed6


Maintain compatibility with Health Handler before javax refactor.

Testing Done:
The previous HealthHandler used `println` to get the newline.

`[tw-mbp-jsmith aurora (health-newline)]$ src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh`

and

```
vagrant@aurora:~$ curl --silent --fail --retry 4 --retry-delay 10 localhost:8081/health
OK
vagrant@aurora:~$
```

Bugs closed: AURORA-1496

Reviewed at https://reviews.apache.org/r/38510/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/1ff336ed
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/1ff336ed
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/1ff336ed

Branch: refs/heads/master
Commit: 1ff336ed644fe7cbb6dbb6f6ccf0862a02dde163
Parents: 9a6832f
Author: Joe Smith <yasumoto7@gmail.com>
Authored: Fri Sep 18 15:30:08 2015 -0700
Committer: Zameer Manji <zmanji@apache.org>
Committed: Fri Sep 18 15:30:08 2015 -0700

----------------------------------------------------------------------
 .../apache/aurora/common/net/http/handlers/HealthHandler.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/1ff336ed/commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
----------------------------------------------------------------------
diff --git a/commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
b/commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
index 731151c..fd5c9e7 100644
--- a/commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
+++ b/commons/src/main/java/org/apache/aurora/common/net/http/handlers/HealthHandler.java
@@ -42,9 +42,9 @@ public class HealthHandler {
    * The plain text response string this servlet returns in the body of its responses to
health
    * check requests when its containing service is healthy.
    */
-  public static final String IS_HEALTHY = "OK";
+  public static final String IS_HEALTHY = "OK\n";
 
-  private static final String IS_NOT_HEALTHY = "SICK";
+  private static final String IS_NOT_HEALTHY = "SICK\n";
 
   private final Supplier<Boolean> healthChecker;
 


Mime
View raw message