aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wfar...@apache.org
Subject aurora git commit: Don't warn about unoptimized Operations
Date Fri, 26 Jun 2015 18:00:29 GMT
Repository: aurora
Updated Branches:
  refs/heads/master 56bb1e693 -> 9ab3ede57


Don't warn about unoptimized Operations

Bugs closed: AURORA-1369

Reviewed at https://reviews.apache.org/r/35840/


Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/9ab3ede5
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/9ab3ede5
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/9ab3ede5

Branch: refs/heads/master
Commit: 9ab3ede57d55c9b938542befdbfa213ca7213718
Parents: 56bb1e6
Author: Stephan Erb <stephan@dev.static-void.de>
Authored: Fri Jun 26 11:00:06 2015 -0700
Committer: Bill Farner <wfarner@apache.org>
Committed: Fri Jun 26 11:00:06 2015 -0700

----------------------------------------------------------------------
 .../aurora/scheduler/storage/log/StreamManagerImpl.java  | 11 -----------
 1 file changed, 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/aurora/blob/9ab3ede5/src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
b/src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
index 12da352..303fecf 100644
--- a/src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
+++ b/src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
@@ -284,9 +284,6 @@ class StreamManagerImpl implements StreamManager {
      * Tries to coalesce a new op into the prior to compact the binary representation and
increase
      * batching.
      *
-     * <p>Its recommended that as new {@code Op}s are added, they be treated here although
they
-     * need not be</p>
-     *
      * @param prior The previous op.
      * @param next The next op to be added.
      * @return {@code true} if the next op was coalesced into the prior, {@code false} otherwise.
@@ -305,13 +302,6 @@ class StreamManagerImpl implements StreamManager {
         case SAVE_FRAMEWORK_ID:
           prior.setSaveFrameworkId(next.getSaveFrameworkId());
           return true;
-
-        case SAVE_CRON_JOB:
-        case REMOVE_JOB:
-        case SAVE_QUOTA:
-        case REMOVE_QUOTA:
-          return false;
-
         case SAVE_TASKS:
           coalesce(prior.getSaveTasks(), next.getSaveTasks());
           return true;
@@ -321,7 +311,6 @@ class StreamManagerImpl implements StreamManager {
         case SAVE_HOST_ATTRIBUTES:
           return coalesce(prior.getSaveHostAttributes(), next.getSaveHostAttributes());
         default:
-          LOG.warning("Unoptimized op: " + priorType);
           return false;
       }
     }


Mime
View raw message