aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject incubator-aurora git commit: Don't double up on verbose kwargs when creating a DirectSchedulerClient.
Date Mon, 12 Jan 2015 18:17:57 GMT
Repository: incubator-aurora
Updated Branches:
  refs/heads/master 1f907da2c -> 326eefa2b


Don't double up on verbose kwargs when creating a DirectSchedulerClient.

Bugs closed: AURORA-998

Reviewed at https://reviews.apache.org/r/29786/


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/326eefa2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/326eefa2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/326eefa2

Branch: refs/heads/master
Commit: 326eefa2b78795cce072fa5b95cdd8c6f6d43758
Parents: 1f907da
Author: Joshua Cohen <jcohen@twopensource.com>
Authored: Mon Jan 12 10:17:39 2015 -0800
Committer: -l <maxim@apache.org>
Committed: Mon Jan 12 10:17:39 2015 -0800

----------------------------------------------------------------------
 src/main/python/apache/aurora/client/api/scheduler_client.py     | 4 ++--
 .../python/apache/aurora/client/api/test_scheduler_client.py     | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/326eefa2/src/main/python/apache/aurora/client/api/scheduler_client.py
----------------------------------------------------------------------
diff --git a/src/main/python/apache/aurora/client/api/scheduler_client.py b/src/main/python/apache/aurora/client/api/scheduler_client.py
index 5d029a8..95e5534 100644
--- a/src/main/python/apache/aurora/client/api/scheduler_client.py
+++ b/src/main/python/apache/aurora/client/api/scheduler_client.py
@@ -179,8 +179,8 @@ class ZookeeperSchedulerClient(SchedulerClient):
 
 
 class DirectSchedulerClient(SchedulerClient):
-  def __init__(self, uri, **kwargs):
-    SchedulerClient.__init__(self, verbose=True, **kwargs)
+  def __init__(self, uri, verbose=True, **kwargs):
+    SchedulerClient.__init__(self, verbose=verbose, **kwargs)
     self._uri = uri
 
   def _connect(self):

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/326eefa2/src/test/python/apache/aurora/client/api/test_scheduler_client.py
----------------------------------------------------------------------
diff --git a/src/test/python/apache/aurora/client/api/test_scheduler_client.py b/src/test/python/apache/aurora/client/api/test_scheduler_client.py
index a6e37d2..0a61948 100644
--- a/src/test/python/apache/aurora/client/api/test_scheduler_client.py
+++ b/src/test/python/apache/aurora/client/api/test_scheduler_client.py
@@ -445,8 +445,7 @@ def test_connect_direct_scheduler_with_user_agent(mock_transport):
   user_agent = 'Some-User-Agent'
   uri = 'https://scheduler.example.com:1337'
 
-  client = scheduler_client.DirectSchedulerClient(uri, user_agent=user_agent)
-
+  client = scheduler_client.DirectSchedulerClient(uri, verbose=True, user_agent=user_agent)
   client._connect_scheduler(uri, mock_time)
 
   mock_transport.assert_called_once_with(uri, user_agent=user_agent)


Mime
View raw message