aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wfar...@apache.org
Subject incubator-aurora git commit: Only print when coverage is below the pass threshold.
Date Wed, 28 Jan 2015 01:18:56 GMT
Repository: incubator-aurora
Updated Branches:
  refs/heads/master 0f735be02 -> 1043db44f


Only print when coverage is below the pass threshold.

Bugs closed: AURORA-1060

Reviewed at https://reviews.apache.org/r/30346/


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/1043db44
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/1043db44
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/1043db44

Branch: refs/heads/master
Commit: 1043db44f0dbfb30b19c26d883b0ee2496168b94
Parents: 0f735be
Author: Bill Farner <wfarner@apache.org>
Authored: Tue Jan 27 17:17:52 2015 -0800
Committer: Bill Farner <wfarner@apache.org>
Committed: Tue Jan 27 17:17:52 2015 -0800

----------------------------------------------------------------------
 .../groovy/org/apache/aurora/build/CoverageReportCheck.groovy    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/1043db44/buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy
----------------------------------------------------------------------
diff --git a/buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy b/buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy
index 85210fa..b996d45 100644
--- a/buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy
+++ b/buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy
@@ -68,7 +68,9 @@ class CoverageReportCheck extends DefaultTask {
     }.findAll()
 
     if (!coverageErrors.isEmpty()) {
-      throw new GradleException(coverageErrors.join('\n'))
+      // We print here and don't fail the build since this metric has proven to be flaky,
+      // and different JVMs can produce different results.
+      println(coverageErrors.join('\n'))
     }
   }
 


Mime
View raw message