aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wfar...@apache.org
Subject incubator-aurora git commit: Don't fail the build when exceeding coverage thresholds.
Date Thu, 13 Nov 2014 01:21:25 GMT
Repository: incubator-aurora
Updated Branches:
  refs/heads/master b80e69c9b -> 6950d50e7


Don't fail the build when exceeding coverage thresholds.

Reviewed at https://reviews.apache.org/r/27949/


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/6950d50e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/6950d50e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/6950d50e

Branch: refs/heads/master
Commit: 6950d50e7ec5e833ad54cb79ffa366b7020dea43
Parents: b80e69c
Author: Joshua Cohen <jcohen@twopensource.com>
Authored: Wed Nov 12 17:21:05 2014 -0800
Committer: Bill Farner <wfarner@apache.org>
Committed: Wed Nov 12 17:21:05 2014 -0800

----------------------------------------------------------------------
 .../src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/6950d50e/buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy
----------------------------------------------------------------------
diff --git a/buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy b/buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy
index 649c53d..f233153 100644
--- a/buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy
+++ b/buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy
@@ -49,7 +49,7 @@ class CoverageReportCheck extends DefaultTask {
     } else {
       def floored = Math.floor(coverage * 100) / 100
       if (floored > (minCoverage + epsilon)) {
-        return("$type coverage of $floored exceeds min instruction coverage of $minCoverage,"
+        println("$type coverage of $floored exceeds min instruction coverage of $minCoverage"
             + " by more than $epsilon, please raise the threshold!")
       } else {
         println("$type coverage of $coverage exceeds minimum coverage of $minCoverage.")


Mime
View raw message