aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevi...@apache.org
Subject incubator-aurora git commit: Fixes for the make pycharm script:
Date Wed, 12 Nov 2014 19:44:36 GMT
Repository: incubator-aurora
Updated Branches:
  refs/heads/master 148f4275b -> 16489f1b6


Fixes for the make pycharm script:

1. Escape $'s
2. Use root directory name as project name
3. Exclude some noisy directories

Testing Done:
$ cat .idea/incubator-aurora.iml

Reviewed at https://reviews.apache.org/r/27892/


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/16489f1b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/16489f1b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/16489f1b

Branch: refs/heads/master
Commit: 16489f1b651471c226c9eaf981bbf0d958a401e7
Parents: 148f427
Author: Joshua Cohen <jcohen@twopensource.com>
Authored: Wed Nov 12 11:44:14 2014 -0800
Committer: Kevin Sweeney <kevints@apache.org>
Committed: Wed Nov 12 11:44:14 2014 -0800

----------------------------------------------------------------------
 build-support/python/make-pycharm-virtualenv | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/16489f1b/build-support/python/make-pycharm-virtualenv
----------------------------------------------------------------------
diff --git a/build-support/python/make-pycharm-virtualenv b/build-support/python/make-pycharm-virtualenv
index 316ead7..8f58d4d 100755
--- a/build-support/python/make-pycharm-virtualenv
+++ b/build-support/python/make-pycharm-virtualenv
@@ -18,6 +18,7 @@ set -e
 HERE=$(cd `dirname "${BASH_SOURCE[0]}"` && pwd)
 BUILDROOT=$HERE/../..
 VENV_DIR=build-support/python/pycharm.venv
+PROJECT_NAME=${PWD##*/}
 
 pushd "$BUILDROOT"
   ./pants goal dependencies --dependencies-external src/test/python:all > requirements.txt
@@ -42,14 +43,17 @@ pushd "$BUILDROOT"
 popd
 
 if [ ! -d .idea ]; then
-  echo Creating PyCharm project at .idea/aurora.iml
+  echo "Creating PyCharm project at .idea/$PROJECT_NAME.iml"
   mkdir .idea
-  cat <<EOF > .idea/aurora.iml
+  cat <<"EOF" > .idea/$PROJECT_NAME.iml
 <?xml version="1.0" encoding="UTF-8"?>
 <module type="PYTHON_MODULE" version="4">
   <component name="NewModuleRootManager">
     <content url="file://$MODULE_DIR$">
       <sourceFolder url="file://$MODULE_DIR$/src/main/python" isTestSource="false" />
+      <excludeFolder url="file://$MODULE_DIR$/.pants.d" />
+      <excludeFolder url="file://$MODULE_DIR$/dist" />
+      <excludeFolder url="file://$MODULE_DIR$/out" />
     </content>
     <orderEntry type="sourceFolder" forTests="false" />
   </component>


Mime
View raw message