aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject [25/50] [abbrv] git commit: Fixed UX issues in showing scheduling details.
Date Sat, 05 Apr 2014 00:05:11 GMT
Fixed UX issues in showing scheduling details.


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/7d99c13c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/7d99c13c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/7d99c13c

Branch: refs/heads/mansu/job_page
Commit: 7d99c13cd0ffb0aceed65455f61b2e92d6968c21
Parents: 1b1c9de
Author: Suman Karumuri <skarumuri@twitter.com>
Authored: Sat Mar 29 22:11:05 2014 -0700
Committer: Suman Karumuri <skarumuri@twitter.com>
Committed: Sat Mar 29 22:21:33 2014 -0700

----------------------------------------------------------------------
 .../apache/aurora/scheduler/http/ui/css/app.css    |  4 ++++
 .../aurora/scheduler/http/ui/taskStatus.html       | 17 ++++++++---------
 2 files changed, 12 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7d99c13c/src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css b/src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css
index e327dc9..e81f561 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css
@@ -29,3 +29,7 @@ ul.breadcrumb {
   margin: 0px auto;
   float: none;
 }
+
+.schedulingStatus {
+  border-bottom: 1px #aaaaaa dashed;
+}

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7d99c13c/src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html b/src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html
index a66b0b0..da59102 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html
@@ -1,18 +1,17 @@
 <task-status>
   <div>
-    <a ng-href='#' title='{{formatedValue | scheduleStatusTooltip}}'>
-      <span ng-if='!showDetails'>
-        <i class='icon-plus'></i> {{formatedValue}}
-      </span>
-      <span ng-if='showDetails'>
-        <i class='icon-minus'></i> {{formatedValue}}
-      </span>
-    </a>
+    <span title='{{formatedValue | scheduleStatusTooltip}}'>
+      <span ng-if='!showDetails'><i class='icon-plus'></i></span>
+      <span ng-if='showDetails'><i class='icon-minus'></i></span>
+      <span class='schedulingStatus'>{{formatedValue}}</span>
+    </span>
 
     <ul ng-if='showDetails'>
       <li ng-repeat='taskEvent in dataRow.taskEvents'>
         {{taskEvent.date}} UTC -
-        <a href='#' title='{{taskEvent.status | scheduleStatusTooltip}}'>{{taskEvent.status}}</a>
+        <span title='{{taskEvent.status | scheduleStatusTooltip}}'>
+          <span class='schedulingStatus'>{{taskEvent.status}}</span>
+        </span>
         <span ng-if='taskEvent.message'> - {{taskEvent.message}}</span>
       </li>
     </ul>


Mime
View raw message