aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject [36/50] [abbrv] git commit: Self review.
Date Sat, 05 Apr 2014 00:05:22 GMT
Self review.


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/7045f691
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/7045f691
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/7045f691

Branch: refs/heads/mansu/job_page
Commit: 7045f6918297d9758521d7a637e1ea5a9124e9d7
Parents: c8f1897
Author: Suman Karumuri <skarumuri@twitter.com>
Authored: Sun Mar 30 22:04:39 2014 -0700
Committer: Suman Karumuri <skarumuri@twitter.com>
Committed: Sun Mar 30 22:30:40 2014 -0700

----------------------------------------------------------------------
 .../resources/org/apache/aurora/scheduler/http/ui/job.html  | 4 ++--
 .../org/apache/aurora/scheduler/http/ui/js/controllers.js   | 9 ++++-----
 2 files changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7045f691/src/main/resources/org/apache/aurora/scheduler/http/ui/job.html
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/job.html b/src/main/resources/org/apache/aurora/scheduler/http/ui/job.html
index e8ea278..e515b51 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/job.html
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/job.html
@@ -1,9 +1,9 @@
 <div>
-  <div ng-show='{{error}}'>
+  <div ng-show='error'>
     <error/>
   </div>
 
-  <div ng-hide='{{error}}'>
+  <div ng-hide='error'>
     <div class='container-fluid'>
       <div>
         <breadcrumb/>

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7045f691/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
index 3318b4c..62206c5 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
@@ -22,7 +22,7 @@ auroraUIControllers.controller('RoleSummaryController',
   function ($scope, auroraClient) {
     $scope.title = 'Scheduled Jobs Summary';
 
-    $scope.error = false;
+    $scope.error = '';
 
     $scope.roleSummaryColumns = [
       {label: 'Role', map: 'role', cellTemplateUrl: 'roleLink.html'},
@@ -60,7 +60,7 @@ auroraUIControllers.controller('JobSummaryController',
     $scope.role = $routeParams.role;
     $scope.environment = $routeParams.environment;
 
-    $scope.error = false;
+    $scope.error = '';
 
     var showResourcesMsg = 'Show Resource Consumption';
     var hideResourcesMsg = 'Hide Resource Consumption';
@@ -216,7 +216,7 @@ auroraUIControllers.controller('JobSummaryController',
 
 auroraUIControllers.controller('QuotaController',
   function ($scope, $filter, auroraClient) {
-    $scope.error = false;
+    $scope.error = '';
 
     $scope.resourcesTableColumns = [
       {label: 'Resource', map: 'resource'},
@@ -264,8 +264,7 @@ auroraUIControllers.controller('QuotaController',
 
 auroraUIControllers.controller('JobController',
   function ($scope, $routeParams, auroraClient) {
-    $scope.error = false;
-    $scope.errorMsg = '';
+    $scope.error = '';
 
     $scope.role = $routeParams.role;
     $scope.environment = $routeParams.environment;


Mime
View raw message