aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject [11/50] [abbrv] git commit: Opening the job page in a new window.
Date Sat, 05 Apr 2014 00:04:57 GMT
Opening the job page in a new window.

dropped a TODO.


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/7d64f874
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/7d64f874
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/7d64f874

Branch: refs/heads/mansu/job_page
Commit: 7d64f87422f567783ceb9a5b5741fa61cf04361e
Parents: b6aca8d
Author: Suman Karumuri <skarumuri@twitter.com>
Authored: Thu Mar 27 13:44:43 2014 -0700
Committer: Suman Karumuri <skarumuri@twitter.com>
Committed: Thu Mar 27 14:04:17 2014 -0700

----------------------------------------------------------------------
 .../org/apache/aurora/scheduler/http/ui/js/controllers.js        | 1 -
 .../org/apache/aurora/scheduler/http/ui/js/directives.js         | 4 ++--
 .../resources/org/apache/aurora/scheduler/http/ui/js/services.js | 1 -
 3 files changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7d64f874/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
index 848d136..153e319 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
@@ -129,7 +129,6 @@ auroraUIControllers.controller('JobSummaryController',
             environment: summary.job.key.environment,
             jobName: summary.job.taskConfig.jobName,
             tasks: summary.job.instanceCount,
-            // TODO(Suman Karumuri): Convert the cron schedule into text for better readability.
             schedule: summary.job.cronSchedule,
             nextCronRun: summary.nextCronRunMs,
             collisionPolicy: getCronCollisionPolicy(summary.job.cronCollisionPolicy),

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7d64f874/src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
index c7f344c..1a093d1 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
@@ -17,8 +17,8 @@ auroraUI.directive('roleEnvLink', function () {
 auroraUI.directive('jobLink', function () {
   return {
     restrict: 'C',
-    template: '<a ng-href="/scheduler/{{dataRow.role}}/{{dataRow.environment}}/{{formatedValue}}">'
-      + '{{formatedValue}}</a>'
+    template: '<a ng-href="/scheduler/{{dataRow.role}}/{{dataRow.environment}}/{{formatedValue}}"'
+      + ' target="_blank">{{formatedValue}}</a>'
   };
 });
 

http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/7d64f874/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
----------------------------------------------------------------------
diff --git a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
index 82758d5..c171e74 100644
--- a/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
+++ b/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
@@ -56,7 +56,6 @@ auroraUI.factory(
             : info.clusterName + " " + title;
         },
 
-        // Not the best way to set the page title, but this works on all browsers.
         setPageTitle: function (serverInfo) {
           $window.document.title = this.getPageTitle(serverInfo);
         }


Mime
View raw message