aurora-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevi...@apache.org
Subject [2/2] git commit: Use user.signingkey for tag-signing.
Date Wed, 19 Feb 2014 00:20:38 GMT
Use user.signingkey for tag-signing.

Rather than use UID require an explicitly-set key ID, following recommendations at [1].

[1] http://www.apache.org/dev/openpgp.html

Testing Done:
Tested with user.signingkey set and unset on local merged master.

Reviewed at https://reviews.apache.org/r/18245/


Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/a55338e3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/a55338e3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/a55338e3

Branch: refs/heads/master
Commit: a55338e3e73094cdf3c1d87926451491314233f0
Parents: 28d7442
Author: Kevin Sweeney <kevints@apache.org>
Authored: Tue Feb 18 16:20:12 2014 -0800
Committer: Kevin Sweeney <kevints@apache.org>
Committed: Tue Feb 18 16:20:12 2014 -0800

----------------------------------------------------------------------
 build-support/release/tag-release | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/a55338e3/build-support/release/tag-release
----------------------------------------------------------------------
diff --git a/build-support/release/tag-release b/build-support/release/tag-release
index 61760aa..abfe505 100755
--- a/build-support/release/tag-release
+++ b/build-support/release/tag-release
@@ -16,6 +16,19 @@ elif [[ "`git rev-parse --abbrev-ref HEAD`" != master ]]; then
 elif [[ "`git rev-parse --show-toplevel`" != "$PWD" ]]; then
   echo "!! This script must be run from the root of the repository."
   exit 1
+elif [[ -z "`git config user.signingkey`" ]]; then
+  cat <<EOF
+!! No GPG signing key is configured for this repository.
+
+To configure one, find your code signing key's ID with
+
+   gpg --list-secret-keys
+
+Then configure it as the signing key for this repository with
+
+   git config user.signingkey YOUR_KEY_ID
+EOF
+  exit 1
 fi
 
 function print_help_and_exit {
@@ -127,8 +140,7 @@ function increment_aurora_version {
 increment_aurora_version
 
 echo == Creating tag $new_tagged_version.
-git tag -u `git config user.email` -s -m "aurora-$new_tagged_version." $new_tagged_version
-
+git tag -s -m "aurora-$new_tagged_version." $new_tagged_version
 
 cat <<EOF
 == Tag created.


Mime
View raw message