atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 69179: Export: Connected: Adds Same Entity GUID to Creation Order Causing Failure to Import
Date Fri, 26 Oct 2018 17:32:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69179/
-----------------------------------------------------------

(Updated Oct. 26, 2018, 5:32 p.m.)


Review request for atlas, Kapildeo Nayak, Madhan Neethiraj, and Nixon Rodrigues.


Changes
-------

Updates


Bugs: ATLAS-2900
    https://issues.apache.org/jira/browse/ATLAS-2900


Repository: atlas


Description
-------

**Root Cause**
The starting entity is a table. During navigation to discover more entities, the entities
that are discovered also discover table using column connection. This causes table to be re-added
to the creation order list.

**Approach**

Convert entity creation order to unique list.

**CURL**

```
curl -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
-d @../docs/export-options.json http://localhost:21000/api/atlas/admin/export > ../docs/hr-1.zip
```


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 5e972a2cd

  repository/src/main/java/org/apache/atlas/repository/util/UniqueList.java eebbc4eff 
  repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java 86afd7f43

  repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java 18e7c419f

  repository/src/test/resources/json/stocksDB-Entities/export-connected.json PRE-CREATION



Diff: https://reviews.apache.org/r/69179/diff/1/


Testing (updated)
-------

**Unit tests**
- Additional tests.
- Minor modification to existing test.

**Functional tests**
Using CURL calls.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/775/


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message