From dev-return-26785-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Sep 17 05:32:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 69AC2180652 for ; Mon, 17 Sep 2018 05:32:39 +0200 (CEST) Received: (qmail 51212 invoked by uid 500); 17 Sep 2018 03:32:38 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 51201 invoked by uid 99); 17 Sep 2018 03:32:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2018 03:32:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 07CF71A1640; Mon, 17 Sep 2018 03:32:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rI-e_WYTme0k; Mon, 17 Sep 2018 03:32:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D81545F437; Mon, 17 Sep 2018 03:32:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 31E49E006D; Mon, 17 Sep 2018 03:32:34 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1FD36C4022F; Mon, 17 Sep 2018 03:32:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2477750033892392793==" MIME-Version: 1.0 Subject: Re: Review Request 68713: Atlas Import Transform Handler Implementation From: Madhan Neethiraj To: Apoorv Naik , Madhan Neethiraj , Ashutosh Mestry Cc: atlas , Sarath Subramanian Date: Mon, 17 Sep 2018 03:32:34 -0000 Message-ID: <20180917033234.17859.96879@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68713/ X-Sender: Madhan Neethiraj References: <20180915223343.22967.94849@reviews-vm2.apache.org> In-Reply-To: <20180915223343.22967.94849@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/HiveDatabaseEntityHandler.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/impexp/AttributeTransform.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/Action.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/HdfsPathEntityHandler.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/HiveColumnEntityHandler.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/TransformationConstants.java X-ReviewBoard-Diff-For: common/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/Condition.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/HiveStorageDescriptorEntityHandler.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============2477750033892392793== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68713/#review208670 ----------------------------------------------------------- common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 50 (patched) key.indexOf ==> value.indexOf common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 51 (patched) key.substring ==> value.substring common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 123 (patched) fromPrefix = actionValue.substring(idxPrefixSep + 1, idxSepDelimiter + 1) ==> actionValue.substring(idxSepDelimiter + 1, idxPrefixSep) common/src/main/java/org/apache/atlas/entitytransform/Action.java Lines 145 (patched) String.replaceFirst() expects the first parameter to be regex - which may not be desirable here. Consider using StringUtils.replace() - Madhan Neethiraj On Sept. 15, 2018, 10:33 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68713/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2018, 10:33 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2873 > https://issues.apache.org/jira/browse/ATLAS-2873 > > > Repository: atlas > > > Description > ------- > > Atlas Import Transform Handler Implementation > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/entitytransform/Action.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/Condition.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/HdfsPathEntityHandler.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/HiveColumnEntityHandler.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/HiveDatabaseEntityHandler.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/HiveStorageDescriptorEntityHandler.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java PRE-CREATION > common/src/main/java/org/apache/atlas/entitytransform/TransformationConstants.java PRE-CREATION > common/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/impexp/AttributeTransform.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/68713/diff/8/ > > > Testing > ------- > > > Thanks, > > Sarath Subramanian > > --===============2477750033892392793==--