atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 68854: REST Endpoint: Delete Type By Name
Date Wed, 26 Sep 2018 20:03:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68854/
-----------------------------------------------------------

(Updated Sept. 26, 2018, 8:03 p.m.)


Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Changes
-------

Updates include: 
- Addressed review comments.
- Pre-commit build details.


Bugs: ATLAS-2892
    https://issues.apache.org/jira/browse/ATLAS-2892


Repository: atlas


Description
-------

**Approach**
- Created new method _AtlasTypeDefStore.deleteTypeByName_.
- Updated UI to use the new REST call.


Diffs (updated)
-----

  dashboardv2/public/js/models/VTag.js fc5a97f516 
  dashboardv2/public/js/views/tag/TagLayoutView.js ff2cb019d7 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 7f196c67f7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
4669286567 
  repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
a1fbf9737b 
  repository/src/test/resources/json/hiveDBv2.json PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 062d664c5f 


Diff: https://reviews.apache.org/r/68854/diff/2/

Changes: https://reviews.apache.org/r/68854/diff/1-2/


Testing (updated)
-------

**Unit tests**
- Added

**Functional tests**
Via web ui.

**Pre-commit build**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/723/


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message