atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 68792: ATLAS-2882: refactored import transformer creation to set context in constructor
Date Fri, 21 Sep 2018 19:25:19 GMT


> On Sept. 21, 2018, 6:08 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/entitytransform/Action.java
> > Line 87 (original), 94 (patched)
> > <https://reviews.apache.org/r/68792/diff/1/?file=2090669#file2090669line94>
> >
> >     Though the context is not used in many actions and conditions, I think it is
better to keep this consistent across all implementations. Can improve readability (since
implementations wouldn't different in few common things - like context).

Removed context from bunch of conditions, where it is not used.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68792/#review208832
-----------------------------------------------------------


On Sept. 21, 2018, 7:21 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68792/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2018, 7:21 p.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval bhatt,
Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2882
>     https://issues.apache.org/jira/browse/ATLAS-2882
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> - refactored import transformer creation to set context in constructor
> - fixed incorrect ObjectIdEquals.matches()
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/entitytransform/Action.java fa1855893 
>   intg/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java e9b2afdf7

>   intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java dd6c66539

>   intg/src/main/java/org/apache/atlas/entitytransform/Condition.java 174b9b48b 
>   intg/src/main/java/org/apache/atlas/entitytransform/HdfsPathEntityHandler.java 1a398eaa9

>   intg/src/main/java/org/apache/atlas/entitytransform/HiveColumnEntityHandler.java fca94b61d

>   intg/src/main/java/org/apache/atlas/entitytransform/HiveDatabaseEntityHandler.java
8a2e81304 
>   intg/src/main/java/org/apache/atlas/entitytransform/HiveStorageDescriptorEntityHandler.java
6a7b17b52 
>   intg/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java b008e6ceb

>   intg/src/main/java/org/apache/atlas/entitytransform/NeedsContext.java 5c16bcfbc 
>   intg/src/main/java/org/apache/atlas/entitytransform/TransformerContext.java a7a77b596

>   intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java
c76f95916 
> 
> 
> Diff: https://reviews.apache.org/r/68792/diff/2/
> 
> 
> Testing
> -------
> 
> Pre-commit tests run - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/678/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message