From dev-return-26216-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Aug 27 01:59:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DAE0C180672 for ; Mon, 27 Aug 2018 01:59:00 +0200 (CEST) Received: (qmail 48212 invoked by uid 500); 26 Aug 2018 23:59:00 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 48201 invoked by uid 99); 26 Aug 2018 23:58:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Aug 2018 23:58:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E6F0FC066E; Sun, 26 Aug 2018 23:58:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.2 X-Spam-Level: * X-Spam-Status: No, score=1.2 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id iJxrd229kxA3; Sun, 26 Aug 2018 23:58:58 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A00285F3E2; Sun, 26 Aug 2018 23:58:57 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 178DAE0110; Sun, 26 Aug 2018 23:58:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DEF69C401F5; Sun, 26 Aug 2018 23:58:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6096651853154935759==" MIME-Version: 1.0 Subject: Re: Review Request 68512: ATLAS-2836: Remove redundant encoding of vertex property keys - #2 From: Madhan Neethiraj To: Apoorv Naik , Ashutosh Mestry , Sarath Subramanian Cc: atlas , Madhan Neethiraj Date: Sun, 26 Aug 2018 23:58:56 -0000 Message-ID: <20180826235856.51457.92342@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68512/ X-Sender: Madhan Neethiraj References: <20180826222736.51458.36302@reviews-vm2.apache.org> In-Reply-To: <20180826222736.51458.36302@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============6096651853154935759== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68512/ ----------------------------------------------------------- (Updated Aug. 26, 2018, 11:58 p.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian. Changes ------- Fix for unit test failiure Bugs: ATLAS-2836 https://issues.apache.org/jira/browse/ATLAS-2836 Repository: atlas Description ------- Removed few more reducdant encoding of property keys Diffs (updated) ----- repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 19069baf3 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 340d86a1c repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 8c93b7c52 repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java 632fa8c8d repository/src/test/java/org/apache/atlas/repository/migration/PathTest.java c87d9a2e7 Diff: https://reviews.apache.org/r/68512/diff/2/ Changes: https://reviews.apache.org/r/68512/diff/1-2/ Testing (updated) ------- Pre-commit test run - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/615/ Thanks, Madhan Neethiraj --===============6096651853154935759==--