From dev-return-25774-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Thu Aug 16 15:58:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6D043180675 for ; Thu, 16 Aug 2018 15:58:47 +0200 (CEST) Received: (qmail 27065 invoked by uid 500); 16 Aug 2018 13:58:46 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 27052 invoked by uid 99); 16 Aug 2018 13:58:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2018 13:58:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8630F1807A0; Thu, 16 Aug 2018 13:58:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.951 X-Spam-Level: X-Spam-Status: No, score=0.951 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id snYDM6xAHt1R; Thu, 16 Aug 2018 13:58:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 902625F300; Thu, 16 Aug 2018 13:58:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E30B3E02F1; Thu, 16 Aug 2018 13:58:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B26D6C41078; Thu, 16 Aug 2018 13:58:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3038049238936536138==" MIME-Version: 1.0 Subject: Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies From: Graham Wallis To: Madhan Neethiraj , Graham Wallis , atlas , David Radley Date: Thu, 16 Aug 2018 13:58:42 -0000 Message-ID: <20180816135842.19575.62129@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Graham Wallis X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68188/ X-Sender: Graham Wallis References: <20180809105116.54546.61432@reviews-vm2.apache.org> In-Reply-To: <20180809105116.54546.61432@reviews-vm2.apache.org> Reply-To: Graham Wallis X-ReviewRequest-Repository: atlas --===============3038049238936536138== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Aug. 9, 2018, 10:51 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 174 (patched) > > > > > > I am wondering what your thoughts are on validation in Atlas. Specifically for cases like: > > - the entity is a proxy but has no homeid. > > - the entity is a proxy but has none manditory attributes set which should not be returned > > - the entity is a proxy so should not be in search results > > > > As coded the caller is responsible for this sort of validation. Thanks David - good suggestions. There is already validation (in addEntityProxy) that the metadataCollectionId is non null - this will prevent creation of a proxy with a null homeId. I have added filtering out of proxy entities from search methods (using DSL or searchParameters). - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68188/#review207015 ----------------------------------------------------------- On Aug. 16, 2018, 1:56 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68188/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 1:56 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS_2808: Support for entity proxies > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java a892551f789cb2a4b21a4f0124a4b6b94bfecd1c > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java dc2be412b9ec1b07d7c7befc722810273464cd3f > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9c4b9f2323cae76ed226b3980086c2b331d521d2 > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 2153a5a9e62ecf3e4a4c847b64edc29c1fb8eafc > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 52c3745642f3eb2af00cb61e10d710c781b100b7 > > > Diff: https://reviews.apache.org/r/68188/diff/2/ > > > Testing > ------- > > Tested with saveRelationshipReferenceCopy between entities that do not exist in the Atlas repository. > > > Thanks, > > Graham Wallis > > --===============3038049238936536138==--