From dev-return-25636-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Aug 13 23:52:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5240D180629 for ; Mon, 13 Aug 2018 23:52:58 +0200 (CEST) Received: (qmail 13455 invoked by uid 500); 13 Aug 2018 21:52:57 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 13443 invoked by uid 99); 13 Aug 2018 21:52:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2018 21:52:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 61D4A1A02A7; Mon, 13 Aug 2018 21:52:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.951 X-Spam-Level: X-Spam-Status: No, score=0.951 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vgEcHUgoYEiC; Mon, 13 Aug 2018 21:52:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 13E085F124; Mon, 13 Aug 2018 21:52:55 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D96BE015E; Mon, 13 Aug 2018 21:52:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1A7D2C41CC0; Mon, 13 Aug 2018 21:52:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1982225377793117881==" MIME-Version: 1.0 Subject: Re: Review Request 68312: AttributeDef Update: Support for Soft Reference From: Ashutosh Mestry To: Apoorv Naik , Nixon Rodrigues , Madhan Neethiraj , Sarath Subramanian Cc: Ashutosh Mestry , atlas Date: Mon, 13 Aug 2018 21:52:53 -0000 Message-ID: <20180813215253.59124.22224@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Mestry X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68312/ X-Sender: Ashutosh Mestry References: <20180813205204.59123.75563@reviews-vm2.apache.org> In-Reply-To: <20180813205204.59123.75563@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: repository/src/test/resources/json/rdbms-db.json X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java X-ReviewBoard-Diff-For: repository/src/test/resources/json/typesDef-soft-ref.json Reply-To: Ashutosh Mestry X-ReviewRequest-Repository: atlas --===============1982225377793117881== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68312/ ----------------------------------------------------------- (Updated Aug. 13, 2018, 9:52 p.m.) Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes ------- Updates include: - Function testing section. Bugs: ATLAS-2813 https://issues.apache.org/jira/browse/ATLAS-2813 Repository: atlas Description ------- **Approach** - Add _options_ field to _AtlasAttributeDef_. - Implement support in _AtlasStructDefStore_. - Update _EntityGraphMapper_ - Update _EntityGraphRetriever_ - Supports array of objects and objects. **Usage** See attached JSON. Diffs ----- intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java c3c85d354f02f6ffb9565a5fc15699c4d06e1ae2 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 137fb30746730cc4d1842891987c342a1bc17af7 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java b6d82dd834b8cc8b3bac630c084b91ac34dd0cec repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java a243fd79cab685174f3a90c5093e84e9f9fa782a repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java PRE-CREATION repository/src/test/resources/json/rdbms-db.json PRE-CREATION repository/src/test/resources/json/typesDef-soft-ref.json PRE-CREATION Diff: https://reviews.apache.org/r/68312/diff/3/ Testing (updated) ------- **Unit tests** Tests verify object, array, map cases. **Functional tests** - Quick Start - Entity creation via REST APIs. - Entity creation via APIs. File Attachments ---------------- rdbms-db.json https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json typesDef-soft-ref.json https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json Thanks, Ashutosh Mestry --===============1982225377793117881==--