From dev-return-25621-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Aug 13 21:07:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 15C20180629 for ; Mon, 13 Aug 2018 21:07:54 +0200 (CEST) Received: (qmail 63249 invoked by uid 500); 13 Aug 2018 19:07:54 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 63232 invoked by uid 99); 13 Aug 2018 19:07:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2018 19:07:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 272B6C9E5A; Mon, 13 Aug 2018 19:07:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.951 X-Spam-Level: X-Spam-Status: No, score=0.951 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rSsA8kHo7Nsm; Mon, 13 Aug 2018 19:07:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2FAF85F3EF; Mon, 13 Aug 2018 19:07:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3C771E00A5; Mon, 13 Aug 2018 19:07:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DB470C4045E; Mon, 13 Aug 2018 19:07:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2057698915656366343==" MIME-Version: 1.0 Subject: Re: Review Request 68270: Cluster Entity Updated after Successful Import if Replication Options are Available in Import Request From: Ashutosh Mestry To: Apoorv Naik , Madhan Neethiraj , Sarath Subramanian Cc: Ashutosh Mestry , atlas Date: Mon, 13 Aug 2018 19:07:49 -0000 Message-ID: <20180813190749.59124.79055@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Mestry X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/68270/ X-Sender: Ashutosh Mestry References: <20180809201936.54546.19046@reviews-vm2.apache.org> In-Reply-To: <20180809201936.54546.19046@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/clusterinfo/AtlasCluster.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/impexp/ReplicationDetails.java Reply-To: Ashutosh Mestry X-ReviewRequest-Repository: atlas --===============2057698915656366343== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68270/ ----------------------------------------------------------- (Updated Aug. 13, 2018, 7:07 p.m.) Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian. Changes ------- Updates include: - Addressed review comments. - Modified _getExportImportAudit_ to return list of _ExportImportAuditEntry_. Bugs: ATLAS-2814 https://issues.apache.org/jira/browse/ATLAS-2814 Repository: atlas Description (updated) ------- **Approach** - New model _ReplicationDetails_ store replication timestamp. - _AuditWriter_ updates appropriate _AtlasCluster_ entity with _ReplicationDetails_. **REST Call** Endpoint: /admin/expimp/audit CURL: curl -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache" http://localhost:21000/api/atlas/admin/expimp/audit?sourceClusterName=cl2 Diffs (updated) ----- client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java f73ba2c6e6c9d05e86eb6c17f923a6dda1df5dd9 intg/src/main/java/org/apache/atlas/model/clusterinfo/AtlasCluster.java 3ce50e38b3af45521c2c83d0e6c05398747bcf86 intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java 85a606c7d3b2158238b2a6defbb9185883434d78 intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportResult.java bfb7637711e08e17fd5f5b16bf121ac541b631a4 intg/src/main/java/org/apache/atlas/model/impexp/ReplicationDetails.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 6a3fbecda84dc48e0df1359c1b5a248958db0a4c repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java fd8e2bfe6bbdb7ae5e66ab67ecdf94e9527d9b09 repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java e90b6b942d359f78ccf59ee955c4667f2033e6c4 repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java b15f828e470eaee972a4ee3f8447f404f813c699 repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 98ef389bd1bf8f87d23a06dc231d4d93f06b2231 repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java 424fb88a5ad2d84ac2245848d061892d40a3f50c repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java b7e943f14084882cd5a3ad22c21168ea098eefcb repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 9e7a119a3abfb50401f9747dad1ffa55facc51ed repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java cfd272fb00a970ab0ba28f96b237de6bd5c694e1 repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java f3803e5ae15a772eb4ff04192a83a5b412631791 repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportTestBase.java fcf90d364950d3afa2c18689d8e22616cfcd3c19 repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java 86ab22294918701270db3ba849f5b0532c1a21a4 repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java dc25e92d7115db31cbd7f99bd1a2cb5f75e766a5 repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 881368ce2c6803c8cf887a1fc91737c045c5e663 server-api/src/main/java/org/apache/atlas/RequestContextV1.java 8506d186978f579c6b18c4347fc7cb2636848f16 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java d4e72620b15f69d258e5a2a96521c65a7ef71114 webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java fc804d2e5a1debd7e728dca1773f91402d41fc26 webapp/src/test/resources/json/export-incremental.json 97108411f9e0c177ac13eb0a8ec3bd4475499f89 webapp/src/test/resources/stocks-base.zip 40c7f37eefb46a944921f6a74a916191704cb9a3 Diff: https://reviews.apache.org/r/68270/diff/4/ Changes: https://reviews.apache.org/r/68270/diff/3-4/ Testing ------- **Unit tests** New tests added. Thanks, Ashutosh Mestry --===============2057698915656366343==--