atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 68427: Add Tag to Imported Entities for the AtlasImportRequest that has 'replicatedTo'
Date Fri, 24 Aug 2018 20:13:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68427/
-----------------------------------------------------------

(Updated Aug. 24, 2018, 8:13 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Updates include: Addressed review comments.


Bugs: ATLAS-2818
    https://issues.apache.org/jira/browse/ATLAS-2818


Repository: atlas


Description
-------

**Approach**
- New method added to _AtlasEntityStore_ to add classifications without updating entity metadata.
- New class _EntityTagger_ added.
- Modified _AudisWriter.ImportAudit_ to include call to _EntityTagger_.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java f56fe227443cde9951e00e67078d91d294fa1df9

  repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java 467d3839a4aff71b7f3d1e03ccd0a828d2ce8c76

  repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 950850e92640fd427d68b8ab1bee5a8f810119cd

  repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 8a184fad519c34033cab6f086e669d97b8784c9a

  repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java dc71c2af4778c2c768ed824132e13e08a272c16f

  repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformsShaper.java
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 6a1a88f4fc714ef069b38cdffd2c5fcc653869e1

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
2bfef788d1ff185c635879f329fa62daafec45ce 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
467ced7748e934b4829ee6f7bbafac39020529ac 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
47960f3f760c322d250559fa1cee2e78b8de2d52 
  repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 08bbcd2fb9b7648535741f3f54f71eae38767a7e

  repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsShaperTest.java
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java b241dda6bff42ea65a6ea6f4dd26536d27a62a71

  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1BulkImportPercentTest.java
73dfe37c786336ec267247a716a27f53e0d74993 


Diff: https://reviews.apache.org/r/68427/diff/5/

Changes: https://reviews.apache.org/r/68427/diff/4-5/


Testing
-------

**Unit tests**
New tests added.

**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/598/


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message