atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies
Date Thu, 16 Aug 2018 13:58:42 GMT


> On Aug. 9, 2018, 10:51 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
> > Lines 174 (patched)
> > <https://reviews.apache.org/r/68188/diff/1/?file=2066993#file2066993line174>
> >
> >     I am wondering what your thoughts are on validation in Atlas. Specifically for
cases like:
> >     - the entity is a proxy but has no homeid. 
> >     - the entity is a proxy but has none manditory attributes set which should not
be returned
> >     - the entity is a proxy so should not be in search results
> >     
> >     As coded the caller is responsible for this sort of validation.

Thanks David - good suggestions.
There is already validation (in addEntityProxy) that the metadataCollectionId is non null
- this will prevent creation of a proxy with a null homeId.
I have added filtering out of proxy entities from search methods (using DSL or searchParameters).


- Graham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review207015
-----------------------------------------------------------


On Aug. 16, 2018, 1:56 p.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 1:56 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java a892551f789cb2a4b21a4f0124a4b6b94bfecd1c

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java dc2be412b9ec1b07d7c7befc722810273464cd3f

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 9c4b9f2323cae76ed226b3980086c2b331d521d2

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
2153a5a9e62ecf3e4a4c847b64edc29c1fb8eafc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
52c3745642f3eb2af00cb61e10d710c781b100b7 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist in the Atlas
repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message