atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 68352: ATLAS-2822: Provide option whether to delete propagated classification on entity delete during add classification
Date Wed, 15 Aug 2018 01:30:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68352/#review207289
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 118 (patched)
<https://reviews.apache.org/r/68352/#comment290620>

    do retrySleepTimeMillis and removePropagations have to be 'public' accessiable? Also,
consider marking all 3 statics here as 'final'.


- Madhan Neethiraj


On Aug. 15, 2018, 12:05 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68352/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2018, 12:05 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2822
>     https://issues.apache.org/jira/browse/ATLAS-2822
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> By default, when an entity is deleted - its associated classifications which have been
propagated to downstream entities will be retained.
> 
> This JIRA provides a boolean option when adding a new classification to an entity - "Remove
Propagations on Entity Delete"
> 
> When this flag is set to :
> 
> TRUE - Propagated classifications are removed during entity delete
> 
> FALSE - Propagated classifications are retained during entity delete
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java d63b376a4 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 23ff5d28c

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 6422399f9

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
5aa40271b 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
3668e4796 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
b07ca1dcc 
>   repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java
ce62ec555 
>   repository/src/test/resources/tag-propagation-data-1.zip 2c605499f871c59a470fdfbe2892e02e1805c7cd

>   repository/src/test/resources/tag-propagation-data.zip 336f4fa6cfb7f2b593ef56b55d0a7354c25fb3bc

>   webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
d50db0625 
> 
> 
> Diff: https://reviews.apache.org/r/68352/diff/2/
> 
> 
> Testing
> -------
> 
> * Added UT to cover this case.
> 
> * Validated using REST Client.
> 
> * PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/566/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message