atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 68168: Fix for: EntityGraphmapper.addClassifications Does not Update modificationTimestamp
Date Mon, 06 Aug 2018 17:04:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68168/#review206888
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
Lines 928 (patched)
<https://reviews.apache.org/r/68168/#comment290010>

    Consider moving the call to updateModificationMetadata() after this loop.


- Madhan Neethiraj


On Aug. 3, 2018, 7:14 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68168/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2018, 7:14 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2805
>     https://issues.apache.org/jira/browse/ATLAS-2805
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> As described in the JIRA.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
25c91be60a052d572c92f1a2cba77471d3819000 
> 
> 
> Diff: https://reviews.apache.org/r/68168/diff/2/
> 
> 
> Testing
> -------
> 
> **Tests**
> Functional tests.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message