From dev-return-24819-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Jul 2 00:27:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2D85C180654 for ; Mon, 2 Jul 2018 00:27:06 +0200 (CEST) Received: (qmail 97891 invoked by uid 500); 1 Jul 2018 22:27:05 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 97880 invoked by uid 99); 1 Jul 2018 22:27:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Jul 2018 22:27:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2F227184D71; Sun, 1 Jul 2018 22:27:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MBSFruxT76jN; Sun, 1 Jul 2018 22:27:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3A3C05F36B; Sun, 1 Jul 2018 22:27:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77BDFE00D3; Sun, 1 Jul 2018 22:27:01 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3DCD5C4015B; Sun, 1 Jul 2018 22:27:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5312291686909191504==" MIME-Version: 1.0 Subject: Re: Review Request 67796: ATLAS-2770: entity-delete fails when Atlas is configured for hard-delete From: Sarath Subramanian To: Apoorv Naik , Mehul Parikh , Ashutosh Mestry , Nixon Rodrigues , Sarath Subramanian Cc: Madhan Neethiraj , atlas Date: Sun, 01 Jul 2018 22:27:01 -0000 Message-ID: <20180701222701.47203.18205@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67796/ X-Sender: Sarath Subramanian X-ReviewBoard-ShipIt: 1 References: <20180701165501.47204.47806@reviews-vm2.apache.org> In-Reply-To: <20180701165501.47204.47806@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas --===============5312291686909191504== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67796/#review205614 ----------------------------------------------------------- Ship it! Ship It! - Sarath Subramanian On July 1, 2018, 9:55 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67796/ > ----------------------------------------------------------- > > (Updated July 1, 2018, 9:55 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Mehul Parikh, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-2770 > https://issues.apache.org/jira/browse/ATLAS-2770 > > > Repository: atlas > > > Description > ------- > > While processing entity-changes, AtlasEntityChangeNotifier attempts to retreive entity details from entity's guid. This call fails for delete operations when Atlas is configured for hard-delete, as the vertex is already deleted. > > Updated the change notifier to avoid entity-retreival for delete operations. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 7ed99a419 > > > Diff: https://reviews.apache.org/r/67796/diff/1/ > > > Testing > ------- > > Verified that Atlas, configured for hard-delete, processes entity-deletes successfully. > > > Thanks, > > Madhan Neethiraj > > --===============5312291686909191504==--