atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Re: Review Request 67797: ATLAS-2771: Add option to exclude internal types when using GET all types using getAllTypeDefs()
Date Wed, 04 Jul 2018 08:03:05 GMT


> On July 2, 2018, 7:30 a.m., Graham Wallis wrote:
> > Do we need a similar filter capability on getAllTypes()?
> 
> Madhan Neethiraj wrote:
>     Graham - this filter applies for getAllTypeDefs() and getTypeDefHeaders(). There
is no getAllTypes() in TypesREST; are you referring to a different method/class?

Yes - I couldn't see why we would want to offer this filter only for the REST user - wouldn't
the Java interface also benefit from it?


- Graham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67797/#review205621
-----------------------------------------------------------


On July 2, 2018, 5:03 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67797/
> -----------------------------------------------------------
> 
> (Updated July 2, 2018, 5:03 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2771
>     https://issues.apache.org/jira/browse/ATLAS-2771
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add option to exclude internal types when using GET all types using getAllTypeDefs()
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 345250a34 
> 
> 
> Diff: https://reviews.apache.org/r/67797/diff/2/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/493/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message