From dev-return-24331-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Sat Jun 2 08:50:28 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 33901180609 for ; Sat, 2 Jun 2018 08:50:28 +0200 (CEST) Received: (qmail 46096 invoked by uid 500); 2 Jun 2018 06:50:27 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 46085 invoked by uid 99); 2 Jun 2018 06:50:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Jun 2018 06:50:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 08A32C00B1; Sat, 2 Jun 2018 06:50:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GPc65OLj0t9Q; Sat, 2 Jun 2018 06:50:25 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B78105F49F; Sat, 2 Jun 2018 06:50:24 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EF750E031B; Sat, 2 Jun 2018 06:50:23 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 45FB2C40183; Sat, 2 Jun 2018 06:50:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4580236203394905495==" MIME-Version: 1.0 Subject: Re: Review Request 67422: ATLAS-2732:Handle kerberos security arguments in import-hbase.sh / import-hive.sh passed via command line From: Madhan Neethiraj To: Madhan Neethiraj , Nixon Rodrigues Cc: atlas , Ramesh Mani Date: Sat, 02 Jun 2018 06:50:22 -0000 Message-ID: <20180602065022.23879.32107@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67422/ X-Sender: Madhan Neethiraj References: <20180602013145.24175.50204@reviews-vm2.apache.org> In-Reply-To: <20180602013145.24175.50204@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============4580236203394905495== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67422/#review204219 ----------------------------------------------------------- addons/hbase-bridge/src/bin/import-hbase.sh Line 130 (original), 129 (patched) Instead of specifically looking for "-D", consider the following to collect arguments for the import tool in IMPORT_ARGS and the rest in JVM_ARGS: #!/bin/bash IMPORT_ARGS= JVM_ARGS= while true do option=$1 shift case "$option" in -d) IMPORT_ARGS="$IMPORT_ARGS -d $1"; shift;; -t) IMPORT_ARGS="$IMPORT_ARGS -t $1"; shift;; --database) IMPORT_ARGS="$IMPORT_ARGS --database $1"; shift;; --table) IMPORT_ARGS="$IMPORT_ARGS --table $1"; shift;; "") break;; *) JVM_ARGS="$JVM_ARGS $option" esac done echo JVM_ARGS=$JVM_ARGS echo IMPORT_ARGS=$IMPORT_ARGS - Madhan Neethiraj On June 2, 2018, 1:31 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67422/ > ----------------------------------------------------------- > > (Updated June 2, 2018, 1:31 a.m.) > > > Review request for atlas, Madhan Neethiraj and Nixon Rodrigues. > > > Bugs: ATLAS-2732 > https://issues.apache.org/jira/browse/ATLAS-2732 > > > Repository: atlas > > > Description > ------- > > ATLAS-2732:Handle kerberos security arguments in import-hbase.sh / import-hive.sh passed via command line > > > Diffs > ----- > > addons/hbase-bridge/src/bin/import-hbase.sh 0a5989f > addons/hive-bridge/src/bin/import-hive.sh 98f4c84 > > > Diff: https://reviews.apache.org/r/67422/diff/1/ > > > Testing > ------- > > Tested in Local VM > > > Thanks, > > Ramesh Mani > > --===============4580236203394905495==--