From dev-return-24116-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Thu May 24 02:09:15 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 495AA180645 for ; Thu, 24 May 2018 02:09:14 +0200 (CEST) Received: (qmail 52074 invoked by uid 500); 24 May 2018 00:09:08 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 52063 invoked by uid 99); 24 May 2018 00:09:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 May 2018 00:09:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5AC7C1A2C23; Thu, 24 May 2018 00:09:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7b22IYXg1dgh; Thu, 24 May 2018 00:09:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2E9DE5F340; Thu, 24 May 2018 00:09:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C573EE012B; Thu, 24 May 2018 00:09:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AFF1FC40221; Thu, 24 May 2018 00:09:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8844047824595706241==" MIME-Version: 1.0 Subject: Re: Review Request 67275: ATLAS-2715: Create audit events for term-entity association and disassociation From: Madhan Neethiraj To: Apoorv Naik , Madhan Neethiraj , Ashutosh Mestry Cc: atlas , Sarath Subramanian Date: Thu, 24 May 2018 00:09:04 -0000 Message-ID: <20180524000904.6761.19879@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/67275/ X-Sender: Madhan Neethiraj References: <20180523220409.6762.23378@reviews-vm2.apache.org> In-Reply-To: <20180523220409.6762.23378@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============8844047824595706241== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67275/#review203718 ----------------------------------------------------------- repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java Lines 139 (patched) Adding all attributes of the term in this audit log doesn't seem useful. Instead, having the following should be enough: - term guid - term name - term qualifiedName Currently audit log has all attributes of the term, including the following: - anchor - classifications - longDescription - shortDescription - assignedEntities repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java Lines 150 (patched) Same comment as above (line #139). repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 178 (patched) Consider renaming onTermAddedToEntities() to onTermAdded(), for consistency with other methods here. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 187 (patched) Same comment as for EntityAuditListener.onTermAdded() repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 196 (patched) Consider renaming onTermDeletedFromEntities() to onTermDeleted(), for consistency with other methods here. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 205 (patched) Same comment as for EntityAuditListener.onTermDeleted() - Madhan Neethiraj On May 23, 2018, 10:04 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67275/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 10:04 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2715 > https://issues.apache.org/jira/browse/ATLAS-2715 > > > Repository: atlas > > > Description > ------- > > No audit events are generated when term is associated or removed from entity. This JIRA adds TERM_ADD and TERM_DELETE audit events. > > > Diffs > ----- > > client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java 7077e1529 > dashboardv2/public/js/utils/Enums.js 1e493e52e > intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 9c735a075 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 787f5a9e5 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java a5499e07c > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java a085e8e2d > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 970b14a1a > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java 3656b8501 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 083600eae > server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java ab379e083 > tools/atlas-migration-exporter/src/main/java/org/apache/atlas/migration/NoOpNotificationChangeListener.java 9af7819a6 > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 9de49d4cf > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java dbdf67db7 > > > Diff: https://reviews.apache.org/r/67275/diff/1/ > > > Testing > ------- > > Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/446/console > > > Thanks, > > Sarath Subramanian > > --===============8844047824595706241==--