From dev-return-23883-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Thu May 17 16:52:20 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 64FE7180634 for ; Thu, 17 May 2018 16:52:20 +0200 (CEST) Received: (qmail 80446 invoked by uid 500); 17 May 2018 14:52:19 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 80390 invoked by uid 99); 17 May 2018 14:52:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2018 14:52:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 62F371A363E; Thu, 17 May 2018 14:52:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HYyzEJcfNjf5; Thu, 17 May 2018 14:52:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F23A35F2AA; Thu, 17 May 2018 14:52:15 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4E05FE00C4; Thu, 17 May 2018 14:52:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 397E4C40619; Thu, 17 May 2018 14:52:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3258708804892076350==" MIME-Version: 1.0 Subject: Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds From: Madhan Neethiraj To: Ashutosh Mestry , Madhan Neethiraj Cc: Graham Wallis , atlas , David Radley Date: Thu, 17 May 2018 14:52:15 -0000 Message-ID: <20180517145215.20223.85319@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66949/ X-Sender: Madhan Neethiraj References: <20180516163748.32365.76722@reviews-vm2.apache.org> In-Reply-To: <20180516163748.32365.76722@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============3258708804892076350== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 16, 2018, 4:37 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > > Lines 77 (patched) > > > > > > Shouldn't homeId be added to AtlasObjectId as well? Please review and update. > > Graham Wallis wrote: > I'm not sure - the GUID is still globally unique provides a means to uniquely identify an entity or relationship. The homeId is additional context, but it's not clear to me that it would be required in a reference to an entity or relationship. The purpose of homeId is to enable the enterprise OMRS to determine whether an object originated from (is 'owned' by) Atlas or is something a copy stored in Atlas, of an object that originated in a different repository. The enterprise OMRS uses that information for routing, etc. > I am happy to add homeId to AtlasObjectId (and maybe AtlasRelatedObjectId) if you still think it should be there. If you don't see the need for 'homeId' in AtlasObjectId (and AtlasEntityHeader - which is returned in search results), the current patch is good to go. Please rebase the patch for current master and commit. Thanks! - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review203241 ----------------------------------------------------------- On May 10, 2018, 2:52 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66949/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 2:52 p.m.) > > > Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > ATLAS-2523: Changes to accept external GUIDs and manage homeIds > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 3732556ae > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 7f36a10f5 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java d04daa5d2 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6c0fdbf36 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 78ab206d3 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7490a15b1 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 9fcba6dda > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java cd00639de > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 183a2f6c0 > > > Diff: https://reviews.apache.org/r/66949/diff/3/ > > > Testing > ------- > > Functional testing of these changes to save reference copies of entities and relationships > > > Thanks, > > Graham Wallis > > --===============3258708804892076350==--