atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Review Request 67324: ATLAS-2721: rename attribute displayName as name in classes AtlasGlossary, AtlasGlossaryTerm, AtlasGlossaryCategory
Date Fri, 25 May 2018 14:28:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67324/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik and keval bhatt.


Bugs: ATLAS-2721
    https://issues.apache.org/jira/browse/ATLAS-2721


Repository: atlas


Description
-------

- updated classes AtlasGlossary, AtlasGlossaryTerm and AtlasGlossaryCategory to rename attribute
displayName as name in classes (Apoorv)
- updated UI for this attribute rename (Keval)


Diffs
-----

  addons/models/0000-Area0/0011-glossary_model.json 2e17e8160 
  dashboardv2/public/js/router/Router.js 1f1bd40ad 
  dashboardv2/public/js/templates/glossary/AssignTermLayoutView_tmpl.html 4808ecb2e 
  dashboardv2/public/js/templates/glossary/CreateEditCategoryTermLayoutView_tmpl.html 8f17f4013

  dashboardv2/public/js/templates/glossary/CreateEditGlossaryLayoutView_tmpl.html 4e4470aaa

  dashboardv2/public/js/utils/CommonViewFunction.js 171f6627f 
  dashboardv2/public/js/utils/Utils.js fd2565ae0 
  dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 02b4c6f25 
  dashboardv2/public/js/views/glossary/CreateEditCategoryTermLayoutView.js c88422966 
  dashboardv2/public/js/views/glossary/CreateEditGlossaryLayoutView.js ec29339ce 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 70ec84916 
  dashboardv2/public/js/views/glossary/GlossaryLayoutView.js 0dcd4a380 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0f6ce85c9 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java ccd0b90c3 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java 959d34777

  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java 9fcca5d62

  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 578d4de8e 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java 38ce1477d

  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 589ef7b77 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 80940198e 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java
139b14536 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
918912a9a 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
d276f8146 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
d5644f95d 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 6378ce675 


Diff: https://reviews.apache.org/r/67324/diff/1/


Testing
-------

- verified that Atlas core and UI handles the renamed attribute correctly
- Precommit test run - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/454/


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message