atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nigel Jones <nigel.l.jo...@gmail.com>
Subject Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
Date Wed, 16 May 2018 18:30:31 GMT


> On May 16, 2018, 3:55 p.m., Madhan Neethiraj wrote:
> > distro/pom.xml
> > Lines 123 (patched)
> > <https://reviews.apache.org/r/67060/diff/6/?file=2021118#file2021118line123>
> >
> >     This results in omag-server binaries to be includes in Atlas packaging. Unless
the implementation is hardened with sufficient testing, I would strongly recommend to not
package this module.

This change has already been committed into master & since it was prior to the branch,
into 1.0.

The binary (and dependencies) are indeed included in a distinct archive along with the other
archives as part of the distribution. The OMAG application however runs independently of atlas.
It's a standalone process that cannot access Atlas data, as the atlas local connector has
not yet been checked in (nor that of any other repository). It runs on a separate port. It
cannot interact with hbase,  It facilitates development of repository connectors. As such
we felt the risk was very low.

However if we want to remove it for 1.0 we can, we could either directly reverse the patch,
or I can build a new one for 1.0 with some or all of the changes undone. I presume we would
leave in master. Happy for you to raise a JIRA or just reply here & I can arrange for
that.


- Nigel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67060/#review203230
-----------------------------------------------------------


On May 13, 2018, 9:54 a.m., Nigel Jones wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67060/
> -----------------------------------------------------------
> 
> (Updated May 13, 2018, 9:54 a.m.)
> 
> 
> Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Added OMAG Server to distribution with an easy to launch jar
> (See JIRA for more information)
> 
> 
> Diffs
> -----
> 
>   distro/pom.xml 6431fd86d 
>   distro/src/main/assemblies/omag-server.xml PRE-CREATION 
>   omag-server/README.md PRE-CREATION 
>   omag-server/pom.xml 4c1c98aa3 
> 
> 
> Diff: https://reviews.apache.org/r/67060/diff/6/
> 
> 
> Testing
> -------
> 
> Built atlas
> Checked correct files in distribution archive
> Checked OMAG server launches with default config
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message