atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds
Date Wed, 16 May 2018 16:37:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66949/#review203241
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 77 (patched)
<https://reviews.apache.org/r/66949/#comment285333>

    Shouldn't homeId be added to AtlasObjectId as well? Please review and update.


- Madhan Neethiraj


On May 10, 2018, 2:52 p.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66949/
> -----------------------------------------------------------
> 
> (Updated May 10, 2018, 2:52 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2523: Changes to accept external GUIDs and manage homeIds
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 3732556ae 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 7f36a10f5 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java d04daa5d2

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6c0fdbf36 
>   repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 78ab206d3

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7490a15b1

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
9fcba6dda 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
cd00639de 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
183a2f6c0 
> 
> 
> Diff: https://reviews.apache.org/r/66949/diff/3/
> 
> 
> Testing
> -------
> 
> Functional testing of these changes to save reference copies of entities and relationships
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message