atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Wallis <graham_wal...@uk.ibm.com>
Subject Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Date Wed, 16 May 2018 13:51:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203220
-----------------------------------------------------------



Hi Bogdan

I just raised 3 issues - but they are all related. The key one is that I need to be able to
set repository mode to LOCAL_GRAPH_REPOSITORY (for running in Atlas).
This method was removed when there were two versions of the REST wrapper (one for inside Atlas,
another for the OMAG Server). Now we have one wrapper I need a way of setting the local graph
mode.
The other two issues are just to accommodate the addition of the above and make them consistent.

- Graham Wallis


On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
> 
> (Updated May 15, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell,
and Ruxandra Rosu.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Create configuration for OMAG API in Atlas
> 
> 
> Diffs
> -----
> 
>   om-fwk-ocf/pom.xml 8b1cefd 
>   omag-api/pom.xml 2338286 
>   omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018

>   omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION

>   omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
PRE-CREATION 
>   omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java
ebc9f2a 
>   omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
PRE-CREATION 
>   omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java
1a15215 
>   omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java
c2950c4 
>   omag-server/pom.xml 527c5c3 
>   omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de

>   omag-server/src/main/resources/application.properties PRE-CREATION 
>   omas-assetconsumer/pom.xml 29935e7 
>   omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
80a98f5 
>   omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
 
>   omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
967be5a 
>   omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java
PRE-CREATION 
>   omas-connectedasset/README.md 2f431df 
>   omas-connectedasset/pom.xml 219c972 
>   omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java
8ae6c37 
>   omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java
PRE-CREATION 
>   omrs/pom.xml 50b9898 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6

>   omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
5948482 
>   omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java
PRE-CREATION 
>   omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java
3f85317 
>   omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java
ccf0de6 
>   webapp/pom.xml 03b8408 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1 
>   webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml 23dc063 
> 
> 
> Diff: https://reviews.apache.org/r/67083/diff/3/
> 
> 
> Testing
> -------
> 
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
> 
> 
> Change base URL for the API to "/open-metadata/access-services" 
> 
> 
> Clean maven unused dependenies
> 
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
> 
> 
> File Attachments
> ----------------
> 
> Added apache licence to a properties file
>   https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
>   https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>   https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> 
> 
> Thanks,
> 
> Bogdan Sava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message