atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 67082: ATLAS-2672: Change primitive map type storage in vertex
Date Sat, 12 May 2018 04:35:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67082/#review202985
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 11, 2018, 7:03 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67082/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 7:03 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2672
>     https://issues.apache.org/jira/browse/ATLAS-2672
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Currently primitive map type in atlas is stored in vertex as:
> 
> typeName.mapAttr      = [key1, key2, key3]
> typeName.mapAttr.key1 = value1
> typeName.mapAttr.key2 = value2
> typeName.mapAttr.key3 = value3
> Since JanusGraph supports Map datatype, we can store map value within a single vertex
property.
> 
> Also we need to create edge label and property key for array and map primitive types.
> 
> 
> Diffs
> -----
> 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
3636ca65a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java f48ccef05 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
f75f7862d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7490a15b1

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
d285e6964 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
cd00639de 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
183a2f6c0 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
e4947282a 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
56dc5bdaf 
> 
> 
> Diff: https://reviews.apache.org/r/67082/diff/3/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/385/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message