atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 67033: ATLAS-2666:Add unit test to KafkaBridge
Date Thu, 10 May 2018 03:33:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67033/#review202820
-----------------------------------------------------------




addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
Lines 84 (patched)
<https://reviews.apache.org/r/67033/#comment284807>

    GUID is not an attribute of AtlasEntity. Consider the following:
    
    AtlasEntity getTopicEntityWithGuid(String guid) {
      AtlasEntity ret = new AtlasEntity(KafkaDataTypes.KAFKA_TOPIC.getName());
    
      ret.setGuid(guid);
      
      return ret;
    }


- Madhan Neethiraj


On May 9, 2018, 8:50 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67033/
> -----------------------------------------------------------
> 
> (Updated May 9, 2018, 8:50 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2666:Add unit test to KafkaBridge
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/src/test/resources/policy-store.txt 048affe 
>   addons/hbase-bridge/src/test/resources/policy-store.txt 048affe 
>   addons/hive-bridge/src/test/resources/policy-store.txt 048affe 
>   addons/kafka-bridge/pom.xml 52f90d6 
>   addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java da6e7b9

>   addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
PRE-CREATION 
>   addons/kafka-bridge/src/test/resources/atlas-application.properties PRE-CREATION 
>   addons/kafka-bridge/src/test/resources/atlas-log4j.xml PRE-CREATION 
>   addons/kafka-bridge/src/test/resources/users-credentials.properties PRE-CREATION 
>   addons/sqoop-bridge/src/test/resources/policy-store.txt 048affe 
>   addons/storm-bridge/src/test/resources/policy-store.txt 048affe 
> 
> 
> Diff: https://reviews.apache.org/r/67033/diff/2/
> 
> 
> Testing
> -------
> 
> 1) Added unit test
> 2) No Integration test for this now, so skipped that.
> 3) This patch addresses the exceptions in Kafka bridge module build.
> 
> 
> Verified in PRE-COMMIT https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/362/console
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message