atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 67028: ATLAS-2662: Remove complex array and map attribute's edge information from entity vertex
Date Wed, 09 May 2018 22:26:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67028/
-----------------------------------------------------------

(Updated May 9, 2018, 3:26 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.


Changes
-------

addressed review comments.


Bugs: ATLAS-2662
    https://issues.apache.org/jira/browse/ATLAS-2662


Repository: atlas


Description
-------

Currently entities with complex types like: array<AtlasEntity>, array<AtlasStruct>,
map<String, AtlasStruct>, map<String, AtlasEntity> store list of edge ids in the
entity vertex. This JIRA removes all edge id information from vertex and uses edge label and
properties to retrieve such attributes.


Diffs (updated)
-----

  common/src/main/java/org/apache/atlas/repository/Constants.java 16a3aaa15 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5f89ffb59 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java ab5f145af 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 2f870dcd0 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 836710c99 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7540b4c71 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
bd0dc0b44 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
f28d771db 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
172854925 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
0d654712e 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasComplexAttributesTest.java
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
0913e6ff6 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityTestBase.java
PRE-CREATION 


Diff: https://reviews.apache.org/r/67028/diff/2/

Changes: https://reviews.apache.org/r/67028/diff/1-2/


Testing
-------

Added Unit Test - AtlasComplexAttributesTest to test all complex attributes

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/361/console


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message