atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 66899: Large Notification Messages: Avoid Duplicate Processing
Date Fri, 04 May 2018 16:33:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66899/
-----------------------------------------------------------

(Updated May 4, 2018, 4:33 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Updates include:
- Addressed review comments.
- Updated unit tests.


Bugs: ATLAS-2634
    https://issues.apache.org/jira/browse/ATLAS-2634


Repository: atlas


Description
-------

**Approach**
Simplified approach.

**Algorithm**
 - Modified: _NotificationHookConsumer_:
   - when commit() fails, record current offset of the message.
   - on receiving a message
      - if _offset_ is same as that of the received message, skip processing the message,
go ahead and commit.
      - reset recorded offset.
Added appropriate log messages.

**Additional Refactoring**
None.


Diffs (updated)
-----

  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 80dc51423 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 7a4596a7e

  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
d2b3dfdab 


Diff: https://reviews.apache.org/r/66899/diff/4/

Changes: https://reviews.apache.org/r/66899/diff/3-4/


Testing
-------

**Unit tests**
Additional unit tests to test specific scenarios.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message