atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 66869: Glossary Bugfixes
Date Tue, 01 May 2018 21:54:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66869/#review202228
-----------------------------------------------------------


Fix it, then Ship it!





intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java
Lines 40 (patched)
<https://reviews.apache.org/r/66869/#comment283976>

    Consider adding a copy constructor, to avoid unnecessary call to generate internal guid:
    
      protected AtlasBaseModelObject(AtlasBaseModelObject that) {
        this.guid = that.guid;
      }
      
    Also, update all derived classes to call this copy constructor from their copy constructor
implementation.


- Madhan Neethiraj


On May 1, 2018, 9:38 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66869/
> -----------------------------------------------------------
> 
> (Updated May 1, 2018, 9:38 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2612, ATLAS-2613, ATLAS-2614, ATLAS-2616, ATLAS-2625, ATLAS-2626, ATLAS-2627,
ATLAS-2628, and ATLAS-2629
>     https://issues.apache.org/jira/browse/ATLAS-2612
>     https://issues.apache.org/jira/browse/ATLAS-2613
>     https://issues.apache.org/jira/browse/ATLAS-2614
>     https://issues.apache.org/jira/browse/ATLAS-2616
>     https://issues.apache.org/jira/browse/ATLAS-2625
>     https://issues.apache.org/jira/browse/ATLAS-2626
>     https://issues.apache.org/jira/browse/ATLAS-2627
>     https://issues.apache.org/jira/browse/ATLAS-2628
>     https://issues.apache.org/jira/browse/ATLAS-2629
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fixes for ATLAS-2612, ATLAS-2613, ATLAS-2614, ATLAS-2616, ATLAS-2625, ATLAS-2626, ATLAS-2627,
ATLAS-2628, ATLAS-2629
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3efe41c95 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 5f6654aee 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java 3c5f41827 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java a3e0a3716

>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java 55fb5809d

>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 3d714a8bd

>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java
bdf5f496f 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryHeader.java
a62493ed7 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java
53781a11e 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java
b4682ed8d 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationHeader.java
28397d9c5 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java 1423b9867

>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 5db0bb068 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java 6a3cc3668

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
91c97776b 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 963bd60e4

>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java
a9279ccd6 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java 10fb40314 
> 
> 
> Diff: https://reviews.apache.org/r/66869/diff/2/
> 
> 
> Testing
> -------
> 
> Local tests execute successfully. 
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/317/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message