From dev-return-22724-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Mon Apr 23 12:24:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B38E9180676 for ; Mon, 23 Apr 2018 12:24:49 +0200 (CEST) Received: (qmail 5328 invoked by uid 500); 23 Apr 2018 10:24:48 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 5281 invoked by uid 99); 23 Apr 2018 10:24:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2018 10:24:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A460DC018E; Mon, 23 Apr 2018 10:24:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id j_JzXdiUdX6K; Mon, 23 Apr 2018 10:24:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2976E5FB5F; Mon, 23 Apr 2018 10:24:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BFB71E0217; Mon, 23 Apr 2018 10:24:45 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 45CB1C4063E; Mon, 23 Apr 2018 10:24:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6689275562182669092==" MIME-Version: 1.0 Subject: Re: Review Request 66632: ATLAS-2571: duplicate declarations From: Graham Wallis To: Graham Wallis , Madhan Neethiraj , David Radley Cc: atlas , Nigel Jones Date: Mon, 23 Apr 2018 10:24:44 -0000 Message-ID: <20180423102444.64394.7952@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Graham Wallis X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66632/ X-Sender: Graham Wallis References: <20180416120335.5208.22422@reviews-vm2.apache.org> In-Reply-To: <20180416120335.5208.22422@reviews-vm2.apache.org> Reply-To: Graham Wallis X-ReviewRequest-Repository: atlas --===============6689275562182669092== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66632/#review201726 ----------------------------------------------------------- +1 for the patch - Graham Wallis On April 16, 2018, 12:03 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66632/ > ----------------------------------------------------------- > > (Updated April 16, 2018, 12:03 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > cleaned up duplicate > - versions of plugins (ie mentioned twice in same file) > - executions in 2 seperate plugin lists (not allowed) > Also removed use of prerequisites - not supported for a non plugin project > > > Diffs > ----- > > addons/falcon-bridge/pom.xml 40e91d4fa > addons/hbase-bridge/pom.xml 28d3e8b50 > addons/hive-bridge/pom.xml b3ebe8ef4 > addons/sqoop-bridge/pom.xml f44002af3 > addons/storm-bridge/pom.xml 484902c39 > graphdb/titan0/pom.xml 28d051b7e > pom.xml a6d126818 > > > Diff: https://reviews.apache.org/r/66632/diff/1/ > > > Testing > ------- > > Initial maven report from build log now mostly clean (still a warning about encoding) > duplicate warnings gone > project still builds ok > > > Thanks, > > Nigel Jones > > --===============6689275562182669092==--