From dev-return-22590-archive-asf-public=cust-asf.ponee.io@atlas.apache.org Wed Apr 18 07:01:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4BF6B18064E for ; Wed, 18 Apr 2018 07:01:00 +0200 (CEST) Received: (qmail 93525 invoked by uid 500); 18 Apr 2018 05:00:59 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 93510 invoked by uid 99); 18 Apr 2018 05:00:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2018 05:00:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AEB3F1806EC; Wed, 18 Apr 2018 05:00:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WBmjzg4uilPL; Wed, 18 Apr 2018 05:00:56 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1760C5FBE9; Wed, 18 Apr 2018 05:00:56 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 95D28E023A; Wed, 18 Apr 2018 05:00:55 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5D50FC40226; Wed, 18 Apr 2018 05:00:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6460644763530875929==" MIME-Version: 1.0 Subject: Re: Review Request 66653: ATLAS-2578: Update metric queries for faster execution From: Madhan Neethiraj To: Madhan Neethiraj , Apoorv Naik , atlas Date: Wed, 18 Apr 2018 05:00:55 -0000 Message-ID: <20180418050055.60021.67173@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66653/ X-Sender: Madhan Neethiraj References: <20180417171328.60021.78092@reviews-vm2.apache.org> In-Reply-To: <20180417171328.60021.78092@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas --===============6460644763530875929== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66653/#review201386 ----------------------------------------------------------- intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java Line 80 (original), 76 (patched) Consider reusing getMetric(groupKey, key), to avoid duplicate code: public Number getNumericMetric(String groupKey, String key) { Object obj = getMetric(groupKey, key); return obj instanceof Number ? (Number) obj : null; } repository/src/main/java/org/apache/atlas/services/MetricsService.java Lines 139 (patched) given activeCount is Map, consider declaring "count" as Number. Same for line #150 and #164 as well. repository/src/main/java/org/apache/atlas/services/MetricsService.java Line 106 (original), 144 (patched) this may not be correct, as the type can be present in 'deletedCount' repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java Line 26 (original), 26 (patched) Would the following be efficient, which avoids having to pass a large list of types (and T.in check on each vertex)? g.V().has('__typeName').has('__state', 'ACTIVE').values('__typeName').groupCount() Similarly for line #29 below: g.V().has('__typeName').has('__state', 'DELETED').values('__typeName').groupCount() webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Line 107 (original), 107 (patched) line break missing - Madhan Neethiraj On April 17, 2018, 5:13 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66653/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 5:13 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2578 > https://issues.apache.org/jira/browse/ATLAS-2578 > > > Repository: atlas > > > Description > ------- > > Updated the business logic around metrics collection to allow faster collection of metrics > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java cfccc96c3 > repository/src/main/java/org/apache/atlas/services/MetricsService.java 0fa68b257 > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 1eb7323ce > repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 72b7261dd > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java cca80b5ff > repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java bdc0f0327 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java b648bc1e6 > > > Diff: https://reviews.apache.org/r/66653/diff/1/ > > > Testing > ------- > > PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/278/ > > > Thanks, > > Apoorv Naik > > --===============6460644763530875929==--