atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Review Request 66804: Import: Set Relationship Defaults when Importing from pre-v1.0
Date Wed, 25 Apr 2018 22:09:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66804/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj and Sarath Subramanian.


Bugs: ATLAS-2610
    https://issues.apache.org/jira/browse/ATLAS-2610


Repository: atlas


Description
-------

**Cases**
_Relationship GUID_: Import from pre-v1.0 will not have relationship guid. This condition
was checked before setting guid.
_Tag Propagation_: Default for pre-v1.0 is _false_. Whereas default from v1.0 to v1.0 is true.
This case was handled.
_Inverse Attribute_: 
  Case of edge creation from table to SD, table to column:
   - There are 2 edges. 
   - Edge creation from child to parent happens during regular entity creation flow.
   - During child entity creation, additional check is performed by looking at value of _inverseAttribute_.
   - Additional methods were added to _EntityMutationContext_ to get parent entity.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
4225a80d5 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java
0a55d55e6 
  repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 5089070b2



Diff: https://reviews.apache.org/r/66804/diff/1/


Testing
-------

**Unit tests**
Additional unit tests added to address new cases.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message