atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 66791: Import: Fix for Glossary Terms
Date Wed, 25 Apr 2018 16:59:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66791/#review201946
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
Lines 78 (patched)
<https://reviews.apache.org/r/66791/#comment283556>

    Consider moving line #78 before line #76.


- Madhan Neethiraj


On April 25, 2018, 4:35 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66791/
> -----------------------------------------------------------
> 
> (Updated April 25, 2018, 4:35 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2602
>     https://issues.apache.org/jira/browse/ATLAS-2602
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Background**
> During entity creation, has a pre-create phase that discovers entities that need to be
created within _AtlasEntity_. For import, this discovery was ignoring the entities present
within relationship attribute.
> 
> **Fix**
> The fix removes the condition.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
f092d1847 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/BulkImporterImpl.java
af310954f 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
91d56ab80 
>   repository/src/test/resources/stocks-glossary.zip PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66791/diff/2/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> - New unit tests cover this case.
> - Additional checks added using EntityDiscovery to query the Graph with known guids after
import succeeds.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message